search

seung-lab / zmesh

Marching Cubes & Mesh Simplification on multi-label 3D images.
GNU General Public License v3.0
59 stars 8 forks source link

perf: marching cubes works at full speed on both C and F order arrays #29

Closed william-silversmith closed 2 years ago

william-silversmith commented 2 years ago

There's gotta be a better way to do this, maybe with macros, but this allows us to handle both C and F arrays without converting them. This saves time and memory and complexity for the end user.

william-silversmith commented 2 years ago

Failing tests are due to differences in the simplification order when compiled on different platforms. An unsimplified test on an ubuntu machine was fine. Since simplification is totally unaffected by these changes, I think it's okay.

william-silversmith commented 2 years ago

This isn't a problem on Ubuntu 16.04 or MacOS 12.3. What the heck is going on?