search

severity1 / custom-amazon-bedrock-agent-action

custom-amazon-bedrock-agent-action is a GitHub Action that uses Amazon Bedrock Agent to analyze code changes in pull requests and provide detailed feedback.
MIT License
25 stars 1 forks source link

Support direct commit to main #28

Closed kpx-dev closed 1 month ago

kpx-dev commented 2 months ago

When testing my repo, I commit directly to main. This action failed. Looks like it only designed for PR. Would be nice to support direct commit as well for easier testing.

severity1 commented 1 month ago

Hi @kpx-dev I just got back form a long holiday, yes ATM this is only designed for PR as it makes comment on the PR itself. Can you give me usecases that would need direct commit support? To be able to support for direct commit one thing that needs to be done first is to add support for inline comments.

kpx-dev commented 1 month ago

@severity1 hi John, it’s more for onboarding support. When I first integrate with this action, I needed to setup proper access to aws account so having it support 1 successful invoke would be nice.

severity1 commented 1 month ago

@kpx-dev i just realised that we dont need to make inline comments work for this as long as a commit can trigger this i can make it work so that the important parts run and if its not being triggered through a PR event then skip the part where it coents on the PR.

I'll submit a PR with this.

severity1 commented 1 month ago

@kpx-dev please try v0.10.0 against push events.

kpx-dev commented 1 month ago

@severity1 Thank you, all work great now! I guess small warning is to upgrade Node:

The following actions use a deprecated Node.js version and will be forced to run on node20: severity1/custom-amazon-bedrock-agent-action@v0.10.0. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

severity1 commented 4 weeks ago

yeah ive got dependabot PRs in queue jus tjeed to test them before i merge.