search

sevntu-checkstyle / sevntu.checkstyle

Additional Checkstyle checks, that could be added as extension to EclipseCS plugin and maven-checkstyle-plugin, Sonar checkstyle plugin, extension for CheckStyle IDEA plugin.
http://sevntu-checkstyle.github.io/sevntu.checkstyle/
190 stars 147 forks source link

Pull #989: Make config files kebab-case #989

Closed stoyanK7 closed 1 year ago

stoyanK7 commented 1 year ago

From https://github.com/checkstyle/checkstyle/pull/12755#discussion_r1111293296

I see the issue now. We are passing sevntu our XML configurations so it can run them. However, our config still references our suppression file naming and not sevntu's file naming. Sevntu still has the old name, and our configuration has the new name. Hence it is not finding the file and failing.

rnveach commented 1 year ago

We are missing travis CI run with a lot of testing.

romani commented 1 year ago

I think we can merge checkstyle repo change first, make a release and update all downstream project after release. Short broken state in this repo is ok.

I sent message to Travis to get more credits for CI execution.

rnveach commented 1 year ago

I think we can merge checkstyle repo change first

@romani Then please tell us how to make main repo's CI green. It is red because we use same file name convention here as in main repo.

romani commented 1 year ago

I made a comment in checkstyle repo.

romani commented 1 year ago

Travis will start on next push

rnveach commented 1 year ago

Travis is still having run issues. I am going to continue reviewing the PR.

@stoyanK7 Please ensure mvn verify runs without issue for sevntu-checks folder.