search

sewageseaweed / CST438_Project1

Group 12 project 1 for CST438
0 stars 2 forks source link

Dao and room #17

Closed sewageseaweed closed 3 years ago

sewageseaweed commented 3 years ago

Created DAO and Room for user favorite quotes. Instrument test cases were created to test if it was working,

bKondo commented 3 years ago

Can confirm: tests seem logical and pass

Concerns:

  1. We should probably remove the UserQuotesUnitTest class, since that doesn't seem to be relevant.
  2. AppDatabase.java, line 12: public abstract UserQuotesDAO userquotes(); needs proper lowerCamelCase
  3. the title and charNamescolumns may need /** summary comments */ to explain what they are
sewageseaweed commented 3 years ago

Alright, applied those changes. Will close pull request and make another with the changes.