seymour-bootay / Mycroft-Android

GNU General Public License v3.0
11 stars 1 forks source link

App needs to be asked first before it starts talking #12

Open marksev1 opened 7 years ago

marksev1 commented 7 years ago

So for notification type application it would be nice if this wasn't the case.. It also may be that it just only once need to be asked on each restart of Mycroft, that might mean that this bug even wouldn't be seen by many. I need to test more to see the exact circumstances when this bug arises.

seymour-bootay commented 7 years ago

do you mean that if the app is not running it does not talk? I tested on my lunch break. With the app in the foreground or background it would respond right away. If you give me a play by play on how you are producing the error, which skills,(I tested with joke and weather) I will try to reproduce this weekend.

marksev1 commented 7 years ago

Correct. If app is not running it doesnt talk.

1.) I start mycroft.sh 2.) I don't start the android mycroft app, nor do I ask it anything. 3.) Mycroft on speakers talks fine, phone app doesn't (using forslunds in developement "events skill", so i have scheduled these intents to be "played out" at a specific time:

      {"SpeakIntent": {"Words": "Good morning Sunshine"}},
      {"CurrentWeatherIntent": {}},
      {"NextDayWeatherIntent": {}},
      {"JokingIntent": {}}
seymour-bootay commented 7 years ago

Gotcha. That would be more of an enhancement. I will have think about how to implement that. It will require a service that is always running and listening on the message bus. I was planning on adding something similar for other reasons. Probably won't be done this weekend but I will try to have it in the next release.

marksev1 commented 7 years ago

Awesome, so will it be again definable if its turned on or not? (pill switch)

seymour-bootay commented 7 years ago

It will probably be a feature you can enable in the settings not on the main screen.