search

seznam / SuperiorMySqlpp

SuperiorMySQL++
GNU Lesser General Public License v3.0
31 stars 20 forks source link

Fix signatures II #143

Closed OpatrilPeter closed 1 week ago

OpatrilPeter commented 4 months ago

Continues https://github.com/seznam/SuperiorMySqlpp/pull/70

OpatrilPeter commented 1 week ago

I've encounter issues with obsolete mysql 5.7 image used for testing. I've tested that modern images mariadb:10.3.39-focal and mysql:8.0.39-debian work correctly, but choosing which way we'll go is left for future work. Please review the relevant commit before merge.

OpatrilPeter commented 1 week ago

We've had an internal team discussion, the plan is to go ahead and upgrade the image to modern mysql. I've added an experimental customization option, the environmental variable TEST_MYSQL_DOCKER_IMAGE; if set, it overrides the default choice.