search

sfall-team / sfall

sfall - Engine modifications for Fallout 2
https://sfall-team.github.io/sfall/
GNU General Public License v3.0
348 stars 41 forks source link

Jet addiction glitches #405

Closed burner1024 closed 3 years ago

burner1024 commented 3 years ago

Strange jet addiction glitches keep coming up: https://github.com/BGforgeNet/Fallout2_Unofficial_Patch/issues/78, https://github.com/BGforgeNet/Fallout2_Restoration_Project/issues/118. I don't really know how to debug this. Some savegame corruption? Fairly sure that it's not caused by scripts.

GelgoogJager commented 3 years ago

I´ll leave one of my saves with an instruction how to reproduce my issue, on my curent run I got addicted to jet, more info here https://github.com/BGforgeNet/Fallout2_Restoration_Project/issues/118: 1. Once you load the save you will be in Vault City, 2. exit the Vault and take quest from Stark to scout Gecko, 3. After Traveling a bit around Gecko in World Map arive in the city and you will find out that your jet addiction permanentaly lowered you Strength and Perception by 1 point each.

FakelsHub commented 3 years ago

*Edit: except when I try to take more jet and then use Jet antidote, the addiction still doesn´t go away, see this save for yourself SLOT11.zip

  1. Have you already taken the antidote in this save or not yet?
  2. What was the stats before the reception/addiction?
  3. In this save, are you under the "JET" drugs or some other?
GelgoogJager commented 3 years ago
  1. No, I just gave myself the antidote through save editor to test the effects
  2. My original stats from character creation were 4 Strength and 6 Perception. The bug causes these stats to go down by incorectly calculating the base Special stats and applying incorect stats debufs (I think, I´m not a programer, so this is just a gues). From what I gather it goes like this, correct behaviour would be: S 4, P 6 then i suffer jet withdrawal so the game lowers the stats by one point to S 3 and P 5. In order to negate the withdrawal effects I take jet and then stats look like this -> S 5 and P 7 (it gives me two points because one dose first negates the effects of withdrawall, which restores the stats to original value, and then gives the bonus + 1 stat bonus and +2 action points bonus). Then comes the bug, say I´m traveling the world and sudenly find town/get into random encounter: my stats would be lowered to S 3 and P 5, i take jet to raise them, but here comes the freaky part: the JET only raises the stats by 1 point´s. This could mean that the game forgot that my stats were lowered by withdrawal and incorectly assumed that the new stats (S 3 and P 5), were the original stats, so next time I suffer from withdrawal syndrome, my stats look like this: S 2 and P 4. And this can go on and on until Strength and Perception are both 1, making the game nearly unplayable.
  3. Yes I´m only addicted to jet, though I was addicted to other drugs before, like buffout.
GelgoogJager commented 3 years ago

More and more I get the feeling that @burner1024 was right in thinking that it could be an engine bug.

FakelsHub commented 3 years ago
  1. No, I just gave myself the antidote through save editor to test the effects

Good!

FakelsHub commented 3 years ago
  1. Yes I´m only addicted to jet, though I was addicted to other drugs before, like buffout.

I mean, is the your character currently on drugs (in savegame)? why do you have AG10 ?

> Now when I created my character my stats were following: 4 S, 6 P, 4 E, 6 C, 7 I, 8 A, 6 L

GelgoogJager commented 3 years ago
  1. Yes I´m only addicted to jet, though I was addicted to other drugs before, like buffout.

I mean, is the your character currently on drugs (in savegame)? why do you have AG10 ?

> Now when I created my character my stats were following: 4 S, 6 P, 4 E, 6 C, 7 I, 8 A, 6 L

Yeah it definetly should be.* You are refering to my older save from previous thread right? The newer one I posted here has the character stats reduced only by withdrawal from jet.

*jet and buffout

FakelsHub commented 3 years ago

The newer one I posted here

here? Where?

FakelsHub commented 3 years ago

you have a horror mess with the use of drugs there, your character is a drug full-addict))))

GelgoogJager commented 3 years ago

you have a horror mess with the use of drugs there, your character is a drug full-addict))))

I mean, that was the plan, lol :D Oh sorry I forgot to attach the save file, here you go

SLOT05.zip

FakelsHub commented 3 years ago

Do you have a save where the character is not a JET addiction? (before get)

GelgoogJager commented 3 years ago

Do you have a save where the character is not a JET addiction? (before get)

Use this save file, now it is further down the main story, but I used the save editor and sucessfully cured my jet addiction with jet antidote before I got messed by the bug SLOT06.zip

GelgoogJager commented 3 years ago

Otherwise once you get messed by the bug it will unfortunately be impossible to cure yourself.

FakelsHub commented 3 years ago

you do not have a dependency to JET in save №11, just the "dependency" sign is frozen, and the statistics have not returned to their previous values. the bug appeared much earlier than you left the VC.

GelgoogJager commented 3 years ago

I think it appeared around Modoc even, here check this save out:

SLOT20.zip

That one was before I even got into Vault City

FakelsHub commented 3 years ago

thanks. I haven't looked at №5 and 6 yet.

FakelsHub commented 3 years ago

I will try to play and reproduce the this bug on your save№6 - in this save, your character is clean and without bugs.

GelgoogJager commented 3 years ago

Ok, let me know how it goes. Remmember, you have to get addicted to jet and then run around the world map, to reproduce the bug.

FakelsHub commented 3 years ago

Yes, I know. By the way, I noticed that for some reason there is no "Addiction to Jet" status in the character's interface after get the addiction. Have you noticed this too?

egornovivan commented 3 years ago

Addiction appears 50/50 when using drugs. Try again.

FakelsHub commented 3 years ago

не учи отца))) кажется в этом и причина, что по какой-то причина не появляется перк зависимости к jet. пойду капать.

FakelsHub commented 3 years ago

I found out the reasons for the appearance of the bug. You can not go to the global map when there is an addiction to JET. :)

The question is when the "Addiction to JET" perk should appear in the perks tab of the character? In save №11, this perk is in the character's perk list. When starting a new game, this perk does not appear after the addiction penalties from JET. Maybe he shouldn't appear? I can't remember how it should work correctly.

egornovivan commented 3 years ago

I can't remember how it should work correctly.

See how the other addictions work, or is there the same problem?

NovaRain commented 3 years ago

When starting a new game, this perk does not appear after the addiction penalties from JET. Maybe he shouldn't appear? I can't remember how it should work correctly.

No, drug addictions should be shown in "Karma" tab under the reputation. There are addiction "perks" but never used.

FakelsHub commented 3 years ago

There are addiction "perks" but never used

Did you mean that never appeared in the list in the Perks tab?

How did PERK_add_jet appear in this list... (in savegame)

NovaRain commented 3 years ago

There are addiction "perks" but never used

Did you mean that never appeared in the list in the Perks tab?

Yes, at least in my tests in UP/RP.

How did PERK_add_jet appear in this list... (in savegame)

I don't know, the engine code and RP scripts don't seem to add addiction "perks" to the player. Although there are checks on the perk when performing withdrawal (item_d_take_drug and item_wd_process).

GelgoogJager commented 3 years ago

There are addiction "perks" but never used

Did you mean that never appeared in the list in the Perks tab?

Yes, at least in my tests in UP/RP.

How did PERK_add_jet appear in this list... (in savegame)

I don't know, the engine code and RP scripts don't seem to add addiction "perks" to the player. Although there are checks on the perk when performing withdrawal (item_d_take_drug and item_wd_process).

So you think the bug is not engine related?