search

sfbrigade / bats-server

Routed is an app to help ambulances direct non-critical patients to hospital emergency rooms with the most availability.
https://routedapp.org/
GNU Affero General Public License v3.0
18 stars 11 forks source link

User does not see feedback in the Reset Password form when the passwords don't match #322

Open francisli opened 9 months ago

francisli commented 9 months ago

Reproduce:

1) Open Routed to the Login page 2) Go to Forgot your password? 3) Submit a registered email address, i.e. op.ems@c4sf.me 4) Open the link in the email (in development, open Mailcatcher on http://localhost:1080) 5) In the Reset Password form, type different passwords in Password/Confirm Password 6) Observe: no feedback, submit button remains disabled

Possible solutions: 1) Perform validation on debounced input changes in Confirm Password field, and show an error message when values don't match. This could be annoying as you may see the error message while you're still typing the password (depending on debounce timing)

2) Leave the Reset Password button enabled, and do the match validation on submit. Note that currently, the back-end is not doing validation, only the front end. Should we do both?

fwextensions commented 9 months ago

1 might be okay with like a 1s - 2s debounce, so it's not validating as you type, just when you pause (which is probably once you've finished typing, unless you're really slow).