Scratch Org error on sfdx falcon:adk:install

MathNerdzRule commented 5 years ago

When creating a scratch org the following error occurs:

The step "Create New Scratch Org" has failed. Its action, "create-scratch-org", returned the following error: SfdxCliError: Failed to create scratch org using demo-scratch-def.json. ENOENT: no such file or directory, open 'C:\sfdx\falcon\falcon-quick-start\test-drive\'C:\sfdx\falcon\falcon-quick-start\test-drive\config\demo-scratch-def.json''

As you can see, it's appending the current directory to the full path it should be using. This is preventing the creation of a new scratch org.

This happens on step 5 and step 8 from the following: https://sfdx-isv.github.io/sfdx-falcon/start/quickstart.html. Here is the error from step 5:

The step "Create New Scratch Org" has failed. Its action, "create-scratch-org", returned the following error: SfdxCliError: Failed to create scratch org using demo-scratch-def.json. ENOENT: no such file or directory, open 'C:\SFDX\falcon\falcon-quick-start\uc-demo-app\'C:\SFDX\falcon\falcon-quick-start\uc-demo-app\config\demo-scratch-def.json''

VivekMChawla commented 5 years ago

@MathNerdzRule - Thanks for reporting this.

Are you on Windows? This may be an issue with how I'm handling the filepath in this case not being fully cross-platform.

Either way, I'll see if I can quickly get a workaround or patch in place.

MathNerdzRule commented 5 years ago

Yes, I'm on Windows. Thank you for looking into it so quickly.

On Mon, Apr 22, 2019, 11:55 AM Vivek M. Chawla notifications@github.com wrote:

@MathNerdzRule https://github.com/MathNerdzRule - Thanks for reporting this.

Are you on Windows? This may be an issue with how I'm handling the filepath in this case not being fully cross-platform.

Either way, I'll see if I can quickly get a workaround or patch in place.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sfdx-isv/sfdx-falcon/issues/152#issuecomment-485457598, or mute the thread https://github.com/notifications/unsubscribe-auth/AGDPHAN7S3SSNPKX62BK673PRXNV7ANCNFSM4HHQRKWQ .

ghost1996110 commented 5 years ago

I am also facing Same Issue

scandala2334 commented 5 years ago

@VivekMChawla I have the same issue and can not create the scratch org. Have you had a chance to develop a workaround for this issue. I am really excited to spin up a Scratch org with FSC installed. I have a big need for this and without this I would not be able to work on a few projects that are pressing.

I have tried this from a CMD window, and I have loaded Bash as my terminal in VSC and it still gives the same error.

VivekMChawla commented 5 years ago

@MathNerdzRule or @scandala2334:

Can you try running the falcon:adk:install command like this:

sfdx falcon:adk:install --falcondebug "ACTION:create-scratch-org"

In the last batch of debug output this creates (the part closest to the end of the command as you scroll up in your terminal), you should see a section that looks like this:

You should also see a section near the end of the debug output that looks like this:

I'd like to confirm what you see for

The _configPath property
The FLAG_DEFINITIONFILE property

If you could share a screenshot, that would be great. Thanks!

scandala2334 commented 5 years ago

@VivekMChawla Thanks for getting back to me as quick as you have.

For Git

VivekMChawla commented 5 years ago

@scandala2334 - Thanks for the quick turnaround. One more thing you can help with.

Can you choose "Y" to view the detailed debug information, copy the entire set of error details that show up, then paste them in a code block in this comment?

Paste your detailed error debug output inside of a ``` code block

Thank you!

VivekMChawla commented 5 years ago

@scandala2334 - I think I see what's going on.

The SFDX-Falcon plugin is expecting there to be a connection in your CLI to a DevHub with the alias intrust.

If you run sfdx force:org:list, do you see an alias named intrust? If not, do you see any DevHubs listed?

If you don't see any Dev Hubs listed, you will need to authenticate to one by using sfdx force:auth:web:login -a YourDevHubAlias

If you've changed the alias to your DevHub from intrust to something else, you'll need to update the local SFDX-Falcon config file for this ADK project by doing the following:

Open the file .sfdx-falcon/sfdx-falcon-config.json
For the devHubAlias key, change the value to whatever your DevHub's alias is. You could also use the username (eg. your-user@your-dev-hub.org).

Give this a try and let me know if it works.

I will add a feature request for a far more user-friendly way of figuring all this out. It also would make sense if I add something that would guide a user through the process of selecting a new DevHub if the one that's specified in the project's SFDX-Falcon config is no longer valid.

scandala2334 commented 5 years ago

@VivekMChawla I actually have a DevHub called Intrust. I forgot that I had changed that for another test I was trying. I changed that file back and now I get the "Cannot find file" error. I pasted the new error messages in the previous message. Thanks again.

This works perfect on my Mac by the way. I use a PC at work though.

ACTION:create-scratch-org:executeAction:      commandFlags:
  ACTION:create-scratch-org:executeAction:       { FLAG_TARGETDEVHUBUSERNAME: 'DevHub',
  ACTION:create-scratch-org:executeAction:         FLAG_DEFINITIONFILE:
  ACTION:create-scratch-org:executeAction:          'F:\\VisualStudio\\Intrust\\fsc-demo-pack\\config\\demo-scratch-def.json',
  ACTION:create-scratch-org:executeAction:         FLAG_SETALIAS: 'sfdx-fsc',
  ACTION:create-scratch-org:executeAction:         FLAG_DURATIONDAYS: 30,
  ACTION:create-scratch-org:executeAction:         FLAG_WAIT: 10,
  ACTION:create-scratch-org:executeAction:         FLAG_NONAMESPACE: true,
  ACTION:create-scratch-org:executeAction:         FLAG_SETDEFAULTUSERNAME: true,
  ACTION:create-scratch-org:executeAction:         FLAG_JSON: true,
  ACTION:create-scratch-org:executeAction:         FLAG_LOGLEVEL: 'error' } } }

VivekMChawla commented 5 years ago

@scandala2334 - Thank you for sharing the error debug info. This is the most interesting part:

CLI Command:       sfdx force:org:create --targetdevhubusername DevHub --definitionfile 'F:\VisualStudio\Intrust\fsc-demo-pack\config\demo-scratch-def.json' --setalias sfdx-fsc --durationdays 30 --wait 10 --nonamespace --setdefaultusername --json --loglevel error
CLI Error Name:    Error
CLI Error Message: ENOENT: no such file or directory, open 'F:\VisualStudio\Intrust\fsc-demo-pack\'F:\VisualStudio\Intrust\fsc-demo-pack\config\demo-scratch-def.json''

The CLI command that's being executed has the expected path for the --definitionfile flag.

CLI Command:       sfdx force:org:create --targetdevhubusername DevHub --definitionfile 'F:\VisualStudio\Intrust\fsc-demo-pack\config\demo-scratch-def.json' --setalias sfdx-fsc --durationdays 30 --wait 10 --nonamespace --setdefaultusername --json --loglevel error

The code that builds the error message gets the CLI Command value from the exact string that is sent to shell.exec(), meaning that this should be what's getting executed behind the scenes by a node child process.

Can you try executing this command directly from inside your Intrust\fsc-demo-pack directory?

sfdx force:org:create --targetdevhubusername DevHub --definitionfile 'F:\VisualStudio\Intrust\fsc-demo-pack\config\demo-scratch-def.json' --setalias sfdx-fsc --durationdays 30 --wait 10 --nonamespace --setdefaultusername --json --loglevel error

I want to see if you get the same error when running this command directly to the CLI. And thanks again for your help in trying to debug this issue.

scandala2334 commented 5 years ago

@VivekMChawla Had you had a chance to figure out the rest of the issue? I can get it to create a sandbox, but not use the full recipe to add FSC into this sandbox. I still do not have a working FSC sandbox. Thanks again for troubleshooting.

scandala2334 commented 5 years ago

@VivekMChawla I had a co-worker who is far more skilled than I am look into this issue. He found a work-around and described the issue below. The work-around would fall in the "unsafe" realm but I think it is important to put this out here in case someone else has this same issue.

The arguments provided to sfdx command that contained file paths in Windows inevitably contained backslashes. When the parseSfdxCommand() function called sanitizeArgument() for the argument value, it saw the backslashes and decided to encapsulate the value with single quotes. Once the file path was encapsulated with single quotes, sfdx no longer considered the file path as fully qualified and attempted to fully qualify the path by prepending the path.

paulknebulaconsulting commented 5 years ago

This issue is affecting myself as well. Windows 10. New install (latest plugin).

kushnit commented 4 years ago

I followed through all the solution provided but issue still persist. Please find the detailed log below

`C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app>sfdx falcon:adk:install --falcondebug "ACTION:create-scratch-org"

The Following Debug Namesapces are Enabled (Debug Depth = 2): [ 'ACTION:create-scratch-org' ]

? The Recipe 'ADK Sample Demo Recipe' will install 'Scratch Org Demo' using the alias 'univ-ctrs_scratch-demo'. If this points to an existing scratch org it will be deleted before installation. Proceed? Yes

Recipe 'ADK Sample Demo Recipe' installing 'Scratch Org Demo' to univ-ctrs_scratch-demo:

Refresh Scratch Org / Delete Current Scratch Org → [5s] Marking scratch org 'univ-ctrs_scratch-demo' for deletion Create New Scratch Org Install Packages Deploy Metadata Create and Configure Users Import/Create Data ACTION:create-scratch-org:executeAction: ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: ACTION:create-scratch-org:executeAction: ACTION_RESULT_DEBUG (Initialized): ACTION:create-scratch-org:executeAction: Result Type: ACTION ACTION:create-scratch-org:executeAction: Result Name: create-scratch-org:executeAction ACTION:create-scratch-org:executeAction: Result Status: WAITING ACTION:create-scratch-org:executeAction: Result Start Time: 1576185866924 (UTC) ACTION:create-scratch-org:executeAction: Result End Time: 0 (UTC) ACTION:create-scratch-org:executeAction: Result Duration: 0 seconds ACTION:create-scratch-org:executeAction: Number of Children: 0 ACTION:create-scratch-org:executeAction: Result Detail: (Depth=4) ACTION:create-scratch-org:executeAction: { actionType: 'sfdx-cli', ACTION:create-scratch-org:executeAction: actionName: 'create-scratch-org', ACTION:create-scratch-org:executeAction: description: 'Create Scratch Org', ACTION:create-scratch-org:executeAction: actionContext: ACTION:create-scratch-org:executeAction: { compileOptions: {}, ACTION:create-scratch-org:executeAction: projectContext: ACTION:create-scratch-org:executeAction: SfdxFalconProject { ACTION:create-scratch-org:executeAction: _sfdxAggregateConfig: ACTION:create-scratch-org:executeAction: { packageDirectories: [ [Object] ], ACTION:create-scratch-org:executeAction: sfdcLoginUrl: 'https://login.salesforce.com', ACTION:create-scratch-org:executeAction: sourceApiVersion: '45.0', ACTION:create-scratch-org:executeAction: plugins: { sfdxFalcon: [Object] }, ACTION:create-scratch-org:executeAction: defaultdevhubusername: 'DevHub', ACTION:create-scratch-org:executeAction: defaultusername: 'nitin.trailhead@gmail.com.falcon' }, ACTION:create-scratch-org:executeAction: _falconProjectConfig: ACTION:create-scratch-org:executeAction: { developerAlias: 'univ-ctrs', ACTION:create-scratch-org:executeAction: developerName: 'Universal Containers', ACTION:create-scratch-org:executeAction: projectAlias: 'uc-demo-app', ACTION:create-scratch-org:executeAction: projectName: 'Universal Containers Demo App', ACTION:create-scratch-org:executeAction: projectFamily: 'ADK', ACTION:create-scratch-org:executeAction: projectType: 'single-demo', ACTION:create-scratch-org:executeAction: defaultRecipe: 'demo-recipe.json', ACTION:create-scratch-org:executeAction: gitRemoteUri: 'https://github.com/kushnit/sfdx-adk-falcontest.git', ACTION:create-scratch-org:executeAction: gitHubUrl: 'https://github.com/my-org/my-repo', ACTION:create-scratch-org:executeAction: projectVersion: '0.0.1', ACTION:create-scratch-org:executeAction: schemaVersion: '0.0.1', ACTION:create-scratch-org:executeAction: pluginVersion: '0.0.93', ACTION:create-scratch-org:executeAction: appxPackage: {}, ACTION:create-scratch-org:executeAction: appxDemo: { demoRecipes: [Array] } }, ACTION:create-scratch-org:executeAction: _falconLocalConfig: ACTION:create-scratch-org:executeAction: { devHubAlias: 'DevHub', ACTION:create-scratch-org:executeAction: envHubAlias: 'NOT_SPECIFIED', ACTION:create-scratch-org:executeAction: pkgOrgAlias: '', ACTION:create-scratch-org:executeAction: appxProject: {}, ACTION:create-scratch-org:executeAction: appxDemo: { installedDemos: [] } }, ACTION:create-scratch-org:executeAction: _falconGlobalConfig: { propertiesTBD: 'TBD' }, ACTION:create-scratch-org:executeAction: _projectPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app', ACTION:create-scratch-org:executeAction: _falconConfigPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\.sfdx-falcon', ACTION:create-scratch-org:executeAction: _templatesPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\.templates', ACTION:create-scratch-org:executeAction: _configPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\config', ACTION:create-scratch-org:executeAction: _mdapiSourcePath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\mdapi-source', ACTION:create-scratch-org:executeAction: _sfdxSourcePath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\sfdx-source', ACTION:create-scratch-org:executeAction: _dataPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\data', ACTION:create-scratch-org:executeAction: _docsPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\docs', ACTION:create-scratch-org:executeAction: _toolsPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\tools', ACTION:create-scratch-org:executeAction: _tempPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\temp', ACTION:create-scratch-org:executeAction: _trackedByGit: null }, ACTION:create-scratch-org:executeAction: devHubAlias: 'DevHub', ACTION:create-scratch-org:executeAction: haltOnError: true, ACTION:create-scratch-org:executeAction: logLevel: 'error', ACTION:create-scratch-org:executeAction: executing: false, ACTION:create-scratch-org:executeAction: targetOrg: ACTION:create-scratch-org:executeAction: { orgName: 'Scratch Org Demo', ACTION:create-scratch-org:executeAction: alias: 'univ-ctrs_scratch-demo', ACTION:create-scratch-org:executeAction: description: 'Installs demo in a Scratch Org', ACTION:create-scratch-org:executeAction: isScratchOrg: true, ACTION:create-scratch-org:executeAction: scratchDefJson: 'demo-scratch-def.json' }, ACTION:create-scratch-org:executeAction: skipActions: [], ACTION:create-scratch-org:executeAction: skipGroups: [], ACTION:create-scratch-org:executeAction: initialized: true, ACTION:create-scratch-org:executeAction: listrExecOptions: ACTION:create-scratch-org:executeAction: { listrContext: [Object: null prototype] {}, ACTION:create-scratch-org:executeAction: listrTask: ACTION:create-scratch-org:executeAction: TaskWrapper { ACTION:create-scratch-org:executeAction: _task: ACTION:create-scratch-org:executeAction: Task { ACTION:create-scratch-org:executeAction: _isScalar: false, ACTION:create-scratch-org:executeAction: observers: [], ACTION:create-scratch-org:executeAction: closed: false, ACTION:create-scratch-org:executeAction: isStopped: false, ACTION:create-scratch-org:executeAction: hasError: false, ACTION:create-scratch-org:executeAction: thrownError: null, ACTION:create-scratch-org:executeAction: _listr: [Listr], ACTION:create-scratch-org:executeAction: _options: [Object], ACTION:create-scratch-org:executeAction: _subtasks: [], ACTION:create-scratch-org:executeAction: _enabledFn: undefined, ACTION:create-scratch-org:executeAction: _isEnabled: true, ACTION:create-scratch-org:executeAction: output: undefined, ACTION:create-scratch-org:executeAction: title: 'Create New Scratch Org', ACTION:create-scratch-org:executeAction: skip: [Function: defaultSkipFn], ACTION:create-scratch-org:executeAction: task: [Function: task], ACTION:create-scratch-org:executeAction: spinner: [Function], ACTION:create-scratch-org:executeAction: _state: 0 }, ACTION:create-scratch-org:executeAction: _errors: [] }, ACTION:create-scratch-org:executeAction: observer: ACTION:create-scratch-org:executeAction: Subscriber { ACTION:create-scratch-org:executeAction: closed: false, ACTION:create-scratch-org:executeAction: _parentOrParents: null, ACTION:create-scratch-org:executeAction: _subscriptions: null, ACTION:create-scratch-org:executeAction: syncErrorValue: null, ACTION:create-scratch-org:executeAction: syncErrorThrown: false, ACTION:create-scratch-org:executeAction: syncErrorThrowable: true, ACTION:create-scratch-org:executeAction: isStopped: false, ACTION:create-scratch-org:executeAction: destination: ACTION:create-scratch-org:executeAction: SafeSubscriber { ACTION:create-scratch-org:executeAction: closed: false, ACTION:create-scratch-org:executeAction: _parentOrParents: null, ACTION:create-scratch-org:executeAction: _subscriptions: null, ACTION:create-scratch-org:executeAction: syncErrorValue: null, ACTION:create-scratch-org:executeAction: syncErrorThrown: false, ACTION:create-scratch-org:executeAction: syncErrorThrowable: false, ACTION:create-scratch-org:executeAction: isStopped: false, ACTION:create-scratch-org:executeAction: destination: [Object], ACTION:create-scratch-org:executeAction: _parentSubscriber: [Circular], ACTION:create-scratch-org:executeAction: _context: [Object], ACTION:create-scratch-org:executeAction: _next: [Function: next], ACTION:create-scratch-org:executeAction: _error: [Function], ACTION:create-scratch-org:executeAction: _complete: [Function] } } } }, ACTION:create-scratch-org:executeAction: actionOptions: ACTION:create-scratch-org:executeAction: { scratchOrgAlias: 'univ-ctrs_scratch-demo', ACTION:create-scratch-org:executeAction: scratchDefJson: 'demo-scratch-def.json' }, ACTION:create-scratch-org:executeAction: executorMessages: null, ACTION:create-scratch-org:executeAction: sfdxCommandDef: null } ACTION:create-scratch-org:executeAction: ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: +0ms ACTION:create-scratch-org:executeAction: ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: ACTION:create-scratch-org:executeAction: ACTION_RESULT_DEBUG (Executor Messages Set): ACTION:create-scratch-org:executeAction: Result Type: ACTION ACTION:create-scratch-org:executeAction: Result Name: create-scratch-org:executeAction ACTION:create-scratch-org:executeAction: Result Status: WAITING ACTION:create-scratch-org:executeAction: Result Start Time: 1576185866924 (UTC) ACTION:create-scratch-org:executeAction: Result End Time: 0 (UTC) ACTION:create-scratch-org:executeAction: Result Duration: 0.025 seconds ACTION:create-scratch-org:executeAction: Number of Children: 0 ACTION:create-scratch-org:executeAction: Result Detail: (Depth=4) ACTION:create-scratch-org:executeAction: { actionType: 'sfdx-cli', ACTION:create-scratch-org:executeAction: actionName: 'create-scratch-org', ACTION:create-scratch-org:executeAction: description: 'Create Scratch Org', ACTION:create-scratch-org:executeAction: actionContext: ACTION:create-scratch-org:executeAction: { compileOptions: {}, ACTION:create-scratch-org:executeAction: projectContext: ACTION:create-scratch-org:executeAction: SfdxFalconProject { ACTION:create-scratch-org:executeAction: _sfdxAggregateConfig: ACTION:create-scratch-org:executeAction: { packageDirectories: [ [Object] ], ACTION:create-scratch-org:executeAction: sfdcLoginUrl: 'https://login.salesforce.com', ACTION:create-scratch-org:executeAction: sourceApiVersion: '45.0', ACTION:create-scratch-org:executeAction: plugins: { sfdxFalcon: [Object] }, ACTION:create-scratch-org:executeAction: defaultdevhubusername: 'DevHub', ACTION:create-scratch-org:executeAction: defaultusername: 'nitin.trailhead@gmail.com.falcon' }, ACTION:create-scratch-org:executeAction: _falconProjectConfig: ACTION:create-scratch-org:executeAction: { developerAlias: 'univ-ctrs', ACTION:create-scratch-org:executeAction: developerName: 'Universal Containers', ACTION:create-scratch-org:executeAction: projectAlias: 'uc-demo-app', ACTION:create-scratch-org:executeAction: projectName: 'Universal Containers Demo App', ACTION:create-scratch-org:executeAction: projectFamily: 'ADK', ACTION:create-scratch-org:executeAction: projectType: 'single-demo', ACTION:create-scratch-org:executeAction: defaultRecipe: 'demo-recipe.json', ACTION:create-scratch-org:executeAction: gitRemoteUri: 'https://github.com/kushnit/sfdx-adk-falcontest.git', ACTION:create-scratch-org:executeAction: gitHubUrl: 'https://github.com/my-org/my-repo', ACTION:create-scratch-org:executeAction: projectVersion: '0.0.1', ACTION:create-scratch-org:executeAction: schemaVersion: '0.0.1', ACTION:create-scratch-org:executeAction: pluginVersion: '0.0.93', ACTION:create-scratch-org:executeAction: appxPackage: {}, ACTION:create-scratch-org:executeAction: appxDemo: { demoRecipes: [Array] } }, ACTION:create-scratch-org:executeAction: _falconLocalConfig: ACTION:create-scratch-org:executeAction: { devHubAlias: 'DevHub', ACTION:create-scratch-org:executeAction: envHubAlias: 'NOT_SPECIFIED', ACTION:create-scratch-org:executeAction: pkgOrgAlias: '', ACTION:create-scratch-org:executeAction: appxProject: {}, ACTION:create-scratch-org:executeAction: appxDemo: { installedDemos: [] } }, ACTION:create-scratch-org:executeAction: _falconGlobalConfig: { propertiesTBD: 'TBD' }, ACTION:create-scratch-org:executeAction: _projectPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app', ACTION:create-scratch-org:executeAction: _falconConfigPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\.sfdx-falcon', ACTION:create-scratch-org:executeAction: _templatesPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\.templates', ACTION:create-scratch-org:executeAction: _configPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\config', ACTION:create-scratch-org:executeAction: _mdapiSourcePath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\mdapi-source', ACTION:create-scratch-org:executeAction: _sfdxSourcePath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\sfdx-source', ACTION:create-scratch-org:executeAction: _dataPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\data', ACTION:create-scratch-org:executeAction: _docsPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\docs', ACTION:create-scratch-org:executeAction: _toolsPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\tools', ACTION:create-scratch-org:executeAction: _tempPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\temp', ACTION:create-scratch-org:executeAction: _trackedByGit: null }, ACTION:create-scratch-org:executeAction: devHubAlias: 'DevHub', ACTION:create-scratch-org:executeAction: haltOnError: true, ACTION:create-scratch-org:executeAction: logLevel: 'error', ACTION:create-scratch-org:executeAction: executing: false, ACTION:create-scratch-org:executeAction: targetOrg: ACTION:create-scratch-org:executeAction: { orgName: 'Scratch Org Demo', ACTION:create-scratch-org:executeAction: alias: 'univ-ctrs_scratch-demo', ACTION:create-scratch-org:executeAction: description: 'Installs demo in a Scratch Org', ACTION:create-scratch-org:executeAction: isScratchOrg: true, ACTION:create-scratch-org:executeAction: scratchDefJson: 'demo-scratch-def.json' }, ACTION:create-scratch-org:executeAction: skipActions: [], ACTION:create-scratch-org:executeAction: skipGroups: [], ACTION:create-scratch-org:executeAction: initialized: true, ACTION:create-scratch-org:executeAction: listrExecOptions: ACTION:create-scratch-org:executeAction: { listrContext: [Object: null prototype] {}, ACTION:create-scratch-org:executeAction: listrTask: ACTION:create-scratch-org:executeAction: TaskWrapper { ACTION:create-scratch-org:executeAction: _task: ACTION:create-scratch-org:executeAction: Task { ACTION:create-scratch-org:executeAction: _isScalar: false, ACTION:create-scratch-org:executeAction: observers: [], ACTION:create-scratch-org:executeAction: closed: false, ACTION:create-scratch-org:executeAction: isStopped: false, ACTION:create-scratch-org:executeAction: hasError: false, ACTION:create-scratch-org:executeAction: thrownError: null, ACTION:create-scratch-org:executeAction: _listr: [Listr], ACTION:create-scratch-org:executeAction: _options: [Object], ACTION:create-scratch-org:executeAction: _subtasks: [], ACTION:create-scratch-org:executeAction: _enabledFn: undefined, ACTION:create-scratch-org:executeAction: _isEnabled: true, ACTION:create-scratch-org:executeAction: output: undefined, ACTION:create-scratch-org:executeAction: title: 'Create New Scratch Org', ACTION:create-scratch-org:executeAction: skip: [Function: defaultSkipFn], ACTION:create-scratch-org:executeAction: task: [Function: task], ACTION:create-scratch-org:executeAction: spinner: [Function], ACTION:create-scratch-org:executeAction: _state: 0 }, ACTION:create-scratch-org:executeAction: _errors: [] }, ACTION:create-scratch-org:executeAction: observer: ACTION:create-scratch-org:executeAction: Subscriber { ACTION:create-scratch-org:executeAction: closed: false, ACTION:create-scratch-org:executeAction: _parentOrParents: null, ACTION:create-scratch-org:executeAction: _subscriptions: null, ACTION:create-scratch-org:executeAction: syncErrorValue: null, ACTION:create-scratch-org:executeAction: syncErrorThrown: false, ACTION:create-scratch-org:executeAction: syncErrorThrowable: true, ACTION:create-scratch-org:executeAction: isStopped: false, ACTION:create-scratch-org:executeAction: destination: ACTION:create-scratch-org:executeAction: SafeSubscriber { ACTION:create-scratch-org:executeAction: closed: false, ACTION:create-scratch-org:executeAction: _parentOrParents: null, ACTION:create-scratch-org:executeAction: _subscriptions: null, ACTION:create-scratch-org:executeAction: syncErrorValue: null, ACTION:create-scratch-org:executeAction: syncErrorThrown: false, ACTION:create-scratch-org:executeAction: syncErrorThrowable: false, ACTION:create-scratch-org:executeAction: isStopped: false, ACTION:create-scratch-org:executeAction: destination: [Object], ACTION:create-scratch-org:executeAction: _parentSubscriber: [Circular], ACTION:create-scratch-org:executeAction: _context: [Object], ACTION:create-scratch-org:executeAction: _next: [Function: next], ACTION:create-scratch-org:executeAction: _error: [Function], ACTION:create-scratch-org:executeAction: _complete: [Function] } } } }, ACTION:create-scratch-org:executeAction: actionOptions: ACTION:create-scratch-org:executeAction: { scratchOrgAlias: 'univ-ctrs_scratch-demo', ACTION:create-scratch-org:executeAction: scratchDefJson: 'demo-scratch-def.json' }, ACTION:create-scratch-org:executeAction: executorMessages: ACTION:create-scratch-org:executeAction: { progressMsg: ACTION:create-scratch-org:executeAction: 'Creating scratch org \'univ-ctrs_scratch-demo\' using demo-scratch-def.json (this can take 3-10 minutes)', ACTION:create-scratch-org:executeAction: errorMsg: 'Failed to create scratch org using demo-scratch-def.json', ACTION:create-scratch-org:executeAction: successMsg: ACTION:create-scratch-org:executeAction: 'Scratch org \'univ-ctrs_scratch-demo\' created successfully using demo-scratch-def.json' }, ACTION:create-scratch-org:executeAction: sfdxCommandDef: null } ACTION:create-scratch-org:executeAction: ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: +24ms ACTION:create-scratch-org:executeAction: ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: ACTION:create-scratch-org:executeAction: ACTION_RESULT_DEBUG (SFDX Command Definition Created): ACTION:create-scratch-org:executeAction: Result Type: ACTION ACTION:create-scratch-org:executeAction: Result Name: create-scratch-org:executeAction ACTION:create-scratch-org:executeAction: Result Status: WAITING ACTION:create-scratch-org:executeAction: Result Start Time: 1576185866924 (UTC) ACTION:create-scratch-org:executeAction: Result End Time: 0 (UTC) ACTION:create-scratch-org:executeAction: Result Duration: 0.047 seconds ACTION:create-scratch-org:executeAction: Number of Children: 0 ACTION:create-scratch-org:executeAction: Result Detail: (Depth=4) ACTION:create-scratch-org:executeAction: { actionType: 'sfdx-cli', ACTION:create-scratch-org:executeAction: actionName: 'create-scratch-org', ACTION:create-scratch-org:executeAction: description: 'Create Scratch Org', ACTION:create-scratch-org:executeAction: actionContext: ACTION:create-scratch-org:executeAction: { compileOptions: {}, ACTION:create-scratch-org:executeAction: projectContext: ACTION:create-scratch-org:executeAction: SfdxFalconProject { ACTION:create-scratch-org:executeAction: _sfdxAggregateConfig: ACTION:create-scratch-org:executeAction: { packageDirectories: [ [Object] ], ACTION:create-scratch-org:executeAction: sfdcLoginUrl: 'https://login.salesforce.com', ACTION:create-scratch-org:executeAction: sourceApiVersion: '45.0', ACTION:create-scratch-org:executeAction: plugins: { sfdxFalcon: [Object] }, ACTION:create-scratch-org:executeAction: defaultdevhubusername: 'DevHub', ACTION:create-scratch-org:executeAction: defaultusername: 'nitin.trailhead@gmail.com.falcon' }, ACTION:create-scratch-org:executeAction: _falconProjectConfig: ACTION:create-scratch-org:executeAction: { developerAlias: 'univ-ctrs', ACTION:create-scratch-org:executeAction: developerName: 'Universal Containers', ACTION:create-scratch-org:executeAction: projectAlias: 'uc-demo-app', ACTION:create-scratch-org:executeAction: projectName: 'Universal Containers Demo App', ACTION:create-scratch-org:executeAction: projectFamily: 'ADK', ACTION:create-scratch-org:executeAction: projectType: 'single-demo', ACTION:create-scratch-org:executeAction: defaultRecipe: 'demo-recipe.json', ACTION:create-scratch-org:executeAction: gitRemoteUri: 'https://github.com/kushnit/sfdx-adk-falcontest.git', ACTION:create-scratch-org:executeAction: gitHubUrl: 'https://github.com/my-org/my-repo', ACTION:create-scratch-org:executeAction: projectVersion: '0.0.1', ACTION:create-scratch-org:executeAction: schemaVersion: '0.0.1', ACTION:create-scratch-org:executeAction: pluginVersion: '0.0.93', ACTION:create-scratch-org:executeAction: appxPackage: {}, ACTION:create-scratch-org:executeAction: appxDemo: { demoRecipes: [Array] } }, ACTION:create-scratch-org:executeAction: _falconLocalConfig: ACTION:create-scratch-org:executeAction: { devHubAlias: 'DevHub', ACTION:create-scratch-org:executeAction: envHubAlias: 'NOT_SPECIFIED', ACTION:create-scratch-org:executeAction: pkgOrgAlias: '', ACTION:create-scratch-org:executeAction: appxProject: {}, ACTION:create-scratch-org:executeAction: appxDemo: { installedDemos: [] } }, ACTION:create-scratch-org:executeAction: _falconGlobalConfig: { propertiesTBD: 'TBD' }, ACTION:create-scratch-org:executeAction: _projectPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app', ACTION:create-scratch-org:executeAction: _falconConfigPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\.sfdx-falcon', ACTION:create-scratch-org:executeAction: _templatesPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\.templates', ACTION:create-scratch-org:executeAction: _configPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\config', ACTION:create-scratch-org:executeAction: _mdapiSourcePath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\mdapi-source', ACTION:create-scratch-org:executeAction: _sfdxSourcePath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\sfdx-source', ACTION:create-scratch-org:executeAction: _dataPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\data', ACTION:create-scratch-org:executeAction: _docsPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\docs', ACTION:create-scratch-org:executeAction: _toolsPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\tools', ACTION:create-scratch-org:executeAction: _tempPath: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\temp', ACTION:create-scratch-org:executeAction: _trackedByGit: null }, ACTION:create-scratch-org:executeAction: devHubAlias: 'DevHub', ACTION:create-scratch-org:executeAction: haltOnError: true, ACTION:create-scratch-org:executeAction: logLevel: 'error', ACTION:create-scratch-org:executeAction: executing: false, ACTION:create-scratch-org:executeAction: targetOrg: ACTION:create-scratch-org:executeAction: { orgName: 'Scratch Org Demo', ACTION:create-scratch-org:executeAction: alias: 'univ-ctrs_scratch-demo', ACTION:create-scratch-org:executeAction: description: 'Installs demo in a Scratch Org', ACTION:create-scratch-org:executeAction: isScratchOrg: true, ACTION:create-scratch-org:executeAction: scratchDefJson: 'demo-scratch-def.json' }, ACTION:create-scratch-org:executeAction: skipActions: [], ACTION:create-scratch-org:executeAction: skipGroups: [], ACTION:create-scratch-org:executeAction: initialized: true, ACTION:create-scratch-org:executeAction: listrExecOptions: ACTION:create-scratch-org:executeAction: { listrContext: [Object: null prototype] {}, ACTION:create-scratch-org:executeAction: listrTask: ACTION:create-scratch-org:executeAction: TaskWrapper { ACTION:create-scratch-org:executeAction: _task: ACTION:create-scratch-org:executeAction: Task { ACTION:create-scratch-org:executeAction: _isScalar: false, ACTION:create-scratch-org:executeAction: observers: [], ACTION:create-scratch-org:executeAction: closed: false, ACTION:create-scratch-org:executeAction: isStopped: false, ACTION:create-scratch-org:executeAction: hasError: false, ACTION:create-scratch-org:executeAction: thrownError: null, ACTION:create-scratch-org:executeAction: _listr: [Listr], ACTION:create-scratch-org:executeAction: _options: [Object], ACTION:create-scratch-org:executeAction: _subtasks: [], ACTION:create-scratch-org:executeAction: _enabledFn: undefined, ACTION:create-scratch-org:executeAction: _isEnabled: true, ACTION:create-scratch-org:executeAction: output: undefined, ACTION:create-scratch-org:executeAction: title: 'Create New Scratch Org', ACTION:create-scratch-org:executeAction: skip: [Function: defaultSkipFn], ACTION:create-scratch-org:executeAction: task: [Function: task], ACTION:create-scratch-org:executeAction: spinner: [Function], ACTION:create-scratch-org:executeAction: _state: 0 }, ACTION:create-scratch-org:executeAction: _errors: [] }, ACTION:create-scratch-org:executeAction: observer: ACTION:create-scratch-org:executeAction: Subscriber { ACTION:create-scratch-org:executeAction: closed: false, ACTION:create-scratch-org:executeAction: _parentOrParents: null, ACTION:create-scratch-org:executeAction: _subscriptions: null, ACTION:create-scratch-org:executeAction: syncErrorValue: null, ACTION:create-scratch-org:executeAction: syncErrorThrown: false, ACTION:create-scratch-org:executeAction: syncErrorThrowable: true, ACTION:create-scratch-org:executeAction: isStopped: false, ACTION:create-scratch-org:executeAction: destination: ACTION:create-scratch-org:executeAction: SafeSubscriber { ACTION:create-scratch-org:executeAction: closed: false, ACTION:create-scratch-org:executeAction: _parentOrParents: null, ACTION:create-scratch-org:executeAction: _subscriptions: null, ACTION:create-scratch-org:executeAction: syncErrorValue: null, ACTION:create-scratch-org:executeAction: syncErrorThrown: false, ACTION:create-scratch-org:executeAction: syncErrorThrowable: false, ACTION:create-scratch-org:executeAction: isStopped: false, ACTION:create-scratch-org:executeAction: destination: [Object], ACTION:create-scratch-org:executeAction: _parentSubscriber: [Circular], ACTION:create-scratch-org:executeAction: _context: [Object], ACTION:create-scratch-org:executeAction: _next: [Function: next], ACTION:create-scratch-org:executeAction: _error: [Function], ACTION:create-scratch-org:executeAction: _complete: [Function] } } } }, ACTION:create-scratch-org:executeAction: actionOptions: ACTION:create-scratch-org:executeAction: { scratchOrgAlias: 'univ-ctrs_scratch-demo', ACTION:create-scratch-org:executeAction: scratchDefJson: 'demo-scratch-def.json' }, ACTION:create-scratch-org:executeAction: executorMessages: ACTION:create-scratch-org:executeAction: { progressMsg: ACTION:create-scratch-org:executeAction: 'Creating scratch org \'univ-ctrs_scratch-demo\' using demo-scratch-def.json (this can take 3-10 minutes)', ACTION:create-scratch-org:executeAction: errorMsg: 'Failed to create scratch org using demo-scratch-def.json', ACTION:create-scratch-org:executeAction: successMsg: ACTION:create-scratch-org:executeAction: 'Scratch org \'univ-ctrs_scratch-demo\' created successfully using demo-scratch-def.json' }, ACTION:create-scratch-org:executeAction: sfdxCommandDef: ACTION:create-scratch-org:executeAction: { command: 'force:org:create', ACTION:create-scratch-org:executeAction: progressMsg: ACTION:create-scratch-org:executeAction: 'Creating scratch org \'univ-ctrs_scratch-demo\' using demo-scratch-def.json (this can take 3-10 minutes)', ACTION:create-scratch-org:executeAction: errorMsg: 'Failed to create scratch org using demo-scratch-def.json', ACTION:create-scratch-org:executeAction: successMsg: ACTION:create-scratch-org:executeAction: 'Scratch org \'univ-ctrs_scratch-demo\' created successfully using demo-scratch-def.json', ACTION:create-scratch-org:executeAction: observer: ACTION:create-scratch-org:executeAction: Subscriber { ACTION:create-scratch-org:executeAction: closed: false, ACTION:create-scratch-org:executeAction: _parentOrParents: null, ACTION:create-scratch-org:executeAction: _subscriptions: null, ACTION:create-scratch-org:executeAction: syncErrorValue: null, ACTION:create-scratch-org:executeAction: syncErrorThrown: false, ACTION:create-scratch-org:executeAction: syncErrorThrowable: true, ACTION:create-scratch-org:executeAction: isStopped: false, ACTION:create-scratch-org:executeAction: destination: ACTION:create-scratch-org:executeAction: SafeSubscriber { ACTION:create-scratch-org:executeAction: closed: false, ACTION:create-scratch-org:executeAction: _parentOrParents: null, ACTION:create-scratch-org:executeAction: _subscriptions: null, ACTION:create-scratch-org:executeAction: syncErrorValue: null, ACTION:create-scratch-org:executeAction: syncErrorThrown: false, ACTION:create-scratch-org:executeAction: syncErrorThrowable: false, ACTION:create-scratch-org:executeAction: isStopped: false, ACTION:create-scratch-org:executeAction: destination: ACTION:create-scratch-org:executeAction: { closed: true, ACTION:create-scratch-org:executeAction: next: [Function: next], ACTION:create-scratch-org:executeAction: error: [Function: error], ACTION:create-scratch-org:executeAction: complete: [Function: complete] }, ACTION:create-scratch-org:executeAction: _parentSubscriber: [Circular], ACTION:create-scratch-org:executeAction: _context: { unsubscribe: [Function: bound ] }, ACTION:create-scratch-org:executeAction: _next: [Function: next], ACTION:create-scratch-org:executeAction: _error: [Function], ACTION:create-scratch-org:executeAction: _complete: [Function] } }, ACTION:create-scratch-org:executeAction: commandArgs: [], ACTION:create-scratch-org:executeAction: commandFlags: ACTION:create-scratch-org:executeAction: { FLAG_TARGETDEVHUBUSERNAME: 'DevHub', ACTION:create-scratch-org:executeAction: FLAG_DEFINITIONFILE: ACTION:create-scratch-org:executeAction: 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\config\demo-scratch-def.json', ACTION:create-scratch-org:executeAction: FLAG_SETALIAS: 'univ-ctrs_scratch-demo', ACTION:create-scratch-org:executeAction: FLAG_DURATIONDAYS: 30, ACTION:create-scratch-org:executeAction: FLAG_WAIT: 10, ACTION:create-scratch-org:executeAction: FLAG_NONAMESPACE: true, ACTION:create-scratch-org:executeAction: FLAG_SETDEFAULTUSERNAME: true, ACTION:create-scratch-org:executeAction: FLAG_JSON: true, ACTION:create-scratch-org:executeAction: FLAG_LOGLEVEL: 'error' } } } ACTION:create-scratch-org:executeAction: ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: - ACTION:create-scratch-org:executeAction: - Refresh Scratch Org √ Delete Current Scratch Org × Create New Scratch Org Install Packages Deploy Metadata Create and Configure Users Import/Create Data

? ERROR DETECTED: Would you like to view detailed debug information? No ERROR running falcon:adk:install: The step "Create New Scratch Org" has failed. Its action, "create-scratch-org", returned the following error: SfdxCliError: Failed to create scratch org using demo-scratch-def.json. ENOENT: no such file or directory, open 'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\'C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app\config\demo-scratch-def.json''

C:\Users\nitin.k1\Documents\SFDX-Projects\ADK-Projects\uc-demo-app>`

tet3 commented 4 years ago

@scandala2334 What is the work-around (if you still remember!) for the issue of the quote-escaped full path being interpreted as relative?

This doesn't seem to be an upstream issue, ie, it's not sfdx itself that's misinterpreting the single-quoted full path as a single element that's relative to the execution context path. I can copy/paste the command from the error message and run it directly from the command line and the scratch org gets created:

$> sfdx force:org:create --targetdevhubusername chfm --definitionfile 'C:\Users\thomas.taylor\Local\fsc-demo-pack\config\demo-scratch-def.json' --setalias sfdx-isv_fsc-demo-pack_scratch-demo --durationdays 30 --wait 10 --nonamespace --setdefaultusername --json --loglevel error

{
  "status": 0,
  "result": {
    "orgId": "00D0t000000BREDACT",
    "username": "test-8kredacted@example.com"
  }
}

tet3 commented 4 years ago

I don't know if this is the workaround that @scandala2334 used, but it worked for me, and yes, is very much USE AT YOUR OWN RISK. I commented out line 195 of C:\Users\[USERNAME]\AppData\Local\sfdx\node_modules\sfdx-falcon\lib\modules\sfdx-falcon-recipe\executors\sfdx.js :

argument = "'" + argument.replace(/'/g, "'\\''") + "'"; // Escape any existing single quotes.

so that the full path to the scratch org definition would get passed without quotes, and then changed it back as soon as the scratch org was created. This will only work if the path to the scratch def file has no spaces in it, but I think falcon requires that you be in a no-space path when you create the project. The command executor then didn't see it as a single, relative filename, and the scratch org def was successfully passed, and the scratch org got created. I'm still waiting for the rest of $ sfdx falcon:adk:install to finish.

ETA: It worked! Had to sort out a couple issues with the fsc-demo-pack itself, but those aren't directly related to Falcon.

scandala2334 commented 4 years ago

@scandala2334 What is the work-around (if you still remember!) for the issue of the quote-escaped full path being interpreted as relative?

This doesn't seem to be an upstream issue, ie, it's not sfdx itself that's misinterpreting the single-quoted full path as a single element that's relative to the execution context path. I can copy/paste the command from the error message and run it directly from the command line and the scratch org gets created:
$> sfdx force:org:create --targetdevhubusername chfm --definitionfile 'C:\Users\thomas.taylor\Local\fsc-demo-pack\config\demo-scratch-def.json' --setalias sfdx-isv_fsc-demo-pack_scratch-demo --durationdays 30 --wait 10 --nonamespace --setdefaultusername --json --loglevel error

{
  "status": 0,
  "result": {
    "orgId": "00D0t000000BREDACT",
    "username": "test-8kredacted@example.com"
  }
}

Sorry, I rarely check the email address that these notifications get sent to. We modified the part of the script that you mentioned and removed the issue of how it translated the information. I appreciate how you worded this and that is why I didn't post the solution. It removes the ability to error check this segment. I really had hoped that SF would put out an official way to generate a scratch org with FSC already installed.

mhamzas commented 3 years ago

I don't know if this is the workaround that @scandala2334 used, but it worked for me, and yes, is very much USE AT YOUR OWN RISK. I commented out line 195 of C:\Users\[USERNAME]\AppData\Local\sfdx\node_modules\sfdx-falcon\lib\modules\sfdx-falcon-recipe\executors\sfdx.js :
argument = "'" + argument.replace(/'/g, "'\\''") + "'"; // Escape any existing single quotes.
so that the full path to the scratch org definition would get passed without quotes, and then changed it back as soon as the scratch org was created. This will only work if the path to the scratch def file has no spaces in it, but I think falcon requires that you be in a no-space path when you create the project. The command executor then didn't see it as a single, relative filename, and the scratch org def was successfully passed, and the scratch org got created. I'm still waiting for the rest of $ sfdx falcon:adk:install to finish.

ETA: It worked! Had to sort out a couple issues with the fsc-demo-pack itself, but those aren't directly related to Falcon.

Thanks, I was facing the same issue on Windows (working fine for MacOS) made the suggested changes including pull-request commit, BTW, Package ID is now: 04t1E000000jb6X

mhamzas commented 2 years ago

https://github.com/sfdx-isv/sfdx-falcon/pull/160 for the fix

sfdx-isv / sfdx-falcon

Scratch Org error on sfdx falcon:adk:install #152