search

sfirke / packagemetrics

A Package for Helping You Choose Which Package to Use
Other
134 stars 6 forks source link

Download and cache the cran data set #33

Closed csgillespie closed 6 years ago

csgillespie commented 6 years ago

Current issue:

The cran packages are stored as a data file in the package.

Fix

Remove the cran data set from the package and get the user to download the CRAN package table as needed. Since this is a relatively slow operation (~2 seconds), the package tibble is cached via the memoise package.

sfirke commented 6 years ago

Hi @csgillespie - thank you for this PR!! If any other package contributor watching this repo can review & merge this week, that would be swell. Otherwise I will take a crack at this in the next week or two.

sfirke commented 6 years ago

This looks great! I reviewed all the code and tested it out locally. I'll add a note to the README telling users to invoke get_cran(forget = TRUE) to refresh CRAN results as needed. Thank you, @csgillespie! (I'll also add you as a contributor to the package)