search

sgkit-dev / bio2zarr

Convert bioinformatics file formats to Zarr
Apache License 2.0
28 stars 7 forks source link

Unpin numpy #283

Closed jeromekelleher closed 3 weeks ago

coveralls commented 1 month ago

Coverage Status

coverage: 98.91%. remained the same when pulling 4dd205e06ebe53634b7442fdec0aab1e3a70f013 on jeromekelleher:numpy2 into 3d7bfec2f1159a93883337bd9a08e6fef3014369 on sgkit-dev:main.

jeromekelleher commented 1 month ago

@tomwhite I think this should give us long-term back-and-forth compatibility with numpy 1.26 and >=2 :crossed_fingers: What do you think?

jeromekelleher commented 2 weeks ago

Did you test if an ICF created with NumPy 1 can be loaded with NumPy 2? If not, that could be done later.

I did check it manually, but ran out of enthusiasm in terms of coming up with a test case to formally check this. I figure it's a rare enough corner case that we can not worry too much about it?