search

sgkit-dev / sgkit

Scalable genetics toolkit
https://sgkit-dev.github.io/sgkit
Apache License 2.0
235 stars 32 forks source link

Test on Python 3.12 #1263

Closed tomwhite closed 1 month ago

tomwhite commented 2 months ago

The first cbgen version that supports Python 3.12 v10.0.5, but this requires NumPy 2, which is why this is failing.

See also #1218

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (51a8ffa) to head (094dc6c).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1263 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 54 54 Lines 4323 4323 ========================================= Hits 4323 4323 ``` | [Flag](https://app.codecov.io/gh/sgkit-dev/sgkit/pull/1263/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/sgkit-dev/sgkit/pull/1263/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mergify[bot] commented 1 month ago

This PR has conflicts, @tomwhite please rebase and push updated version 🙏

jeromekelleher commented 1 month ago

Yeesh, this is looking hairy! Thanks for fighting the good fight here Tom!

tomwhite commented 1 month ago

OK, I've got this passing now! There were a few things that needed fixing: the NumPy 2/cbgen/bio2zarr version constraints, and pkg_resources no longer being supported in Python 3.12.