search

sgkit-dev / vcztools

Partial reimplementation of bcftools for VCF Zarr
Apache License 2.0
4 stars 3 forks source link

Add samples file option to view CLI #76

Closed Will-Tyler closed 2 months ago

Will-Tyler commented 2 months ago

Overview

This pull request adds the -S / --samples-file option to the vcztools view CLI.

This pull request addresses #67, but does not implement the empty-selection semantics.

Testing

I added some validation tests to compare the output from vcztools and bcftools. The tests use the --no-update option because vcztools does not recompute the INFO fields when the user specifies a sample selection (see #45).

tomwhite commented 2 months ago

Thanks @Will-Tyler!

This pull request addresses #67, but does not implement the empty-selection semantics.

I'll merge this now, but would you like to open another issue to track this?