sgkit-dev / vcztools

Partial reimplementation of bcftools for VCF Zarr
Apache License 2.0
3 stars 3 forks source link

Exclude samples #80

Closed Will-Tyler closed 1 month ago

Will-Tyler commented 1 month ago

Overview

The bcftools view CLI allows users to exclude samples from the output with the ^ character. This pull request makes vcztools view do the same.

This pull request closes #74.

Testing

I had some unit and validation tests.

Discussion

bcftools view lets the user simultaneously include samples with -s and exclude samples with -S. I think the expected behavior in different cases (e.g. a sample that is both included and excluded) is not well-defined, so vcztools just throws an assertion error in this implementation. I can try to copy bcftools view's behavior if desired or open a separate issue to track this.

References