sgminer-dev / sgminer

Scrypt GPU miner
GNU General Public License v3.0
631 stars 826 forks source link

Completion of error handling #178

Open elfring opened 10 years ago

elfring commented 10 years ago

I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing.

Would you like to add more error handling for return values from functions like the following?

veox commented 10 years ago

I would much prefer you added it and submitted a pull request.

Also, are you a bot?

elfring commented 10 years ago

I am not a robot! - I try to clarify approaches before something will be written in your favourite programming language.

Are you interested to apply aspect-oriented software development? How do you think about to encapsulate error detection and corresponding exception handling as a reusable aspect in your software?

veox commented 10 years ago

I am not a robot!

Well, all bots I've talked to started with that.

I try to clarify approaches before something will be written in your favourite programming language.

I don't think I have a favourite.

Are you interested to apply aspect-oriented software development?

Kind of. I was thinking more of a complete rewrite in C++/Python (large developer bases, OOP), modular and with asynchronous communication between modules. Doing what you propose warrants a major refactor anyway.

It is best to discuss this on sgminer-devel IMO. This bugtracker is ill-suited for philosophy.

OhGodAPet commented 10 years ago

He sounds a lot like a bot to me.

Bllacky commented 10 years ago

Bot or no bot, he is helpful isn't he ?

sephtin commented 10 years ago

Would be more helpful if he submitted a merge request with the proposed changes.. :)