search

sgrif / mysqlclient-sys

Rust bindings for libmysqlclient
Apache License 2.0
37 stars 31 forks source link

MariaDB to CI, add MySQL MacOS tests, and bump some MySQL tests to 8.4.0 where available (not MacOS) #49

Closed grooverdan closed 4 months ago

grooverdan commented 4 months ago

Thanks for the feedback on #47.

I tried to use OUT_DIR in the CI to show the generated bindings.rs but its not showing in CI unfortunately. Something codebase? Including the DEVELOPMENT.md command directly needed the bindgen installed so was trying to use the existing build.

The diesel builds on MariaDB Windows fails.

version.starts_with("21.") was needed for Linux builds but Windows versions needed version == "21" hence both conditions.

grooverdan commented 4 months ago

CI on vcpkg was failing - https://github.com/grooverdan/mysqlclient-sys/actions/runs/9477291902/job/26111568059 I didn't get to the bottom of it.

Other builds (prior to merge conflict): https://github.com/grooverdan/mysqlclient-sys/actions/runs/9478039583

Still getting diesel failing on MariaDB Windows build even with lib inclusion (assuming I did it right).

Appoligies for beginner looking rust usage.

Hope adding MariaDB functions is ok (though will need to pull the bindings.rs out of CI for autogen if acceptable).

Did you want me to resolve merge conflicts?

weiznich commented 4 months ago

I will take care of the merge conflicts and have a look at the remaining build failures as well. Thanks for putting up everything so far. That's really helpful.

grooverdan commented 4 months ago

Thanks @weiznich for the restructure and getting to the bottom of the vpkg compile issue.

weiznich commented 4 months ago

Thanks for putting in the work for the initial setup. That was helpful. The next step for proper support of more advanced MariaDB features in diesel would be https://github.com/diesel-rs/diesel/issues/1882. Any help is welcome there as well.

grooverdan commented 4 months ago

I have been looking at that one. I think I need some intermediate step to get my rust skills just a little better before attempting it.