Closed sgsellan closed 1 month ago
There's also a question of why we didn't catch this in tests....
@odedstein , would it be a good idea to add 2D tests to https://github.com/sgsellan/gpytoolbox/blob/main/test/test_reach_for_the_spheres.py
This is fixed now by #139
This dumb assert assumes 3D, we should remove it
converged = gpy.reach_for_the_spheres_iteration(state) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/silviasellan/miniconda3/lib/python3.11/site-packages/gpytoolbox/reach_for_the_spheres.py", line 667, in reach_for_the_spheres_iteration if np.any((np.isnan(state.V))) or np.any(doublearea(state.V, state.F)==0) or len(non_manifold_edges(state.F))>0 :