search

sgwilym / nova-deno

A Deno extension for Nova.
https://extensions.panic.com/extensions/co.gwil/co.gwil.deno/
MIT License
13 stars 1 forks source link

Do not provide language features while "Enable Deno Language Features" is turned off #19

Closed belcar-s closed 2 years ago

belcar-s commented 2 years ago

This OR operator might have been making the expression evaluate to true regardless of the value of the setting. I’m not quite sure of why it was added; I was thinking of replacing it with ??, but the call to getOverridableBoolean should never return null, right?

Either way, removing that bit of code seems to fix it.

https://user-images.githubusercontent.com/73370025/163702666-52e109ff-6ac0-4843-8c2e-5ad53e127b2b.mp4

https://user-images.githubusercontent.com/73370025/163702708-ceb551d3-b425-4379-90ed-ecb4c7ee7e04.mp4

sgwilym commented 2 years ago

This must have been accidentally committed by me when testing something. Thank you for fixing these!