Changing facets causes undo/redo to fail

[GoogleCodeExporter]

It looks like facet selections are outside the scope of the operation history 
so that undo can produce bad results if facet selections are changed first.

I accidentally has some facets selected when I added a couple of columns and 
when I deselected the facets and then undid the Add Column operations, I ended 
up with different data than what I started with.

We need to make sure that all Refine state is accounted for in operation 
history.  I also think an operation called "Add column" should probably add a 
cell on every row whether it's selected or not.  For non-selected rows, it 
could be an empty cell.

Original issue reported on code.google.com by tfmorris on 25 Sep 2011 at 8:47

[GoogleCodeExporter]

This is serious. I'll take a look.

Original comment by dfhu...@gmail.com on 26 Sep 2011 at 1:06

• Changed state: Started

[GoogleCodeExporter]

Tom, could you attach your data and operations for which this issue happens? I 
have not been able to reproduce it on first try. Thanks.

Original comment by dfhu...@gmail.com on 26 Sep 2011 at 1:14

[GoogleCodeExporter]

Unfortunately I forgot to export the project in the state it was in.  I've 
attempted to recreate a subset of the operations and it looks like things 
actually get messed during the add column.  If you look at the attached project 
"155 Views" from Column 1 3 was duplicated to the Conference column during the 
Add Column operation.

I had two facets on the YouTube Title column - startsWith('Strata') and 
contains('interviewed') - and had True selected for the first of those when I 
did the column add (ie not all rows were selected).

When I was working before, I was playing with different combinations of the 
facet selections while adding several different columns, so it's possible that 
the data was getting messier and messier during the operations and I later 
misinterpreted that as Undo not working.  I'll have to play with it some more 
to see if I can reproduce exactly what happened (although Add Column shouldn't 
be adding random data, of course).

Original comment by tfmorris on 26 Sep 2011 at 6:08

Attachments:

• strata-scratch.google-refine.tar.gz

[GoogleCodeExporter]

Thanks, Tom. It's not obvious to me why the undo wouldn't work in this case, so 
I'll wait for you to consistently repro the problem before digging into the 
problem.

Original comment by dfhu...@gmail.com on 27 Sep 2011 at 12:34

[GoogleCodeExporter]

Bump all unfinished 2.5 Milestone tags to next release

Original comment by tfmorris on 12 Dec 2011 at 7:56

• Added labels: Milestone-2.6