search

shade-econ / sequence-jacobian

A unified framework to solve and analyze heterogeneous-agent macro models.
MIT License
253 stars 149 forks source link

Stage block 2D choice #14

Open johanneswieland opened 1 year ago

johanneswieland commented 1 year ago

I know the stage block code is still experimental, but I wanted to flag this issue if it has not come up yet.

The function inputs in line 115 of law_of_motion.py do not correspond to the required inputs for forward_policy_shock_2d. Executing this line throws the error 'ShockedPolicyLottery2D' object has no attribute 'i' since the object only has attributes that look like i1 and i2.

https://github.com/shade-econ/sequence-jacobian/blob/ac77f11b90fc70b94633de0526ffa40fec046966/src/sequence_jacobian/blocks/support/law_of_motion.py#L112-L117

bbardoczy commented 1 year ago

Thanks for pointing this out, Johannes. We're planning to introduce some refinements of stage blocks soon, as well as addressing some of the issues raised by the community.

johanneswieland commented 1 year ago

Great, looking forward to it!

On Jan 20, 2023, at 5:51 AM, Bence @.***> wrote:

Thanks for pointing this out, Johannes. We're planning to introduce some refinements of stage blocks soon, as well as addressing some of the issues raised by the community.

— Reply to this email directly, view it on GitHub https://github.com/shade-econ/sequence-jacobian/issues/14#issuecomment-1398424213, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOHSKVPIBJN6PMJT6VADGYTWTKJ43ANCNFSM6AAAAAAUAW3KMA. You are receiving this because you authored the thread.