search

shader-slang / slang

Making it easier to work with shaders
MIT License
2.04k stars 175 forks source link

Investigate loop inversion problem. #4151

Open kaizhangNV opened 4 months ago

kaizhangNV commented 4 months ago

We noticed that some render engine renders artifacts image because of slang in D3D. After some initial investigation, we found out this is related to our loop inversion algorithm. https://github.com/shader-slang/slang/blob/master/source/slang/slang-lower-to-ir.cpp#L10843

We make it an internal option for now and default off, we will re-enable it after figuring out the issue.

bmillsNV commented 4 months ago

Lowering to P2. Will revisit once we get the capture/replay framework up.

swoods-nv commented 3 months ago

Moving to Q3 -- would like to get @expipiplus1 to take a look

expipiplus1 commented 2 months ago

@kaizhangNV do you have a reproducer for this now?

bmillsNV commented 2 months ago

We'll wait for capture/replay and use that to investigate :)

bmillsNV commented 1 month ago

Capture/replay wont work for this issue. Can we push this one out?

bmillsNV commented 1 month ago

@expipiplus1 we discussed and capture/replay won't help here as it's a visual artifact. Capture/replay doesn't have the ability to see rendered images so we won't be able to use it.