search

shadowmage45 / SSTULabs

Dev repository for testing/unfinished KSP parts/plugins/etc.
Other
62 stars 41 forks source link

SRB-A bugged with RealPlume installed #823

Open al2me6 opened 4 years ago

al2me6 commented 4 years ago

Steps to reproduce:

Observe that text on sliders do not adjust when clicked, until the menu is closed and re-opened, and that solid fuel amount does not update.

Logs attached: https://gist.github.com/al2me6/10f18076b841307315dfc4f938af528b

shadowmage45 commented 4 years ago

Thanks for including the logs. Reviewing now, and will let you know what I find out.

shadowmage45 commented 4 years ago

One quick (and major) issue that I can see from the logs, that will need to be corrected before I can continue investigations:

al2me6 commented 4 years ago

I apologize for the delay.

Unfortunately, installing CRP seems to have made no difference: https://gist.github.com/al2me6/a9382b6a050da84a1f9b84c152b68986.

shadowmage45 commented 4 years ago

What is this file you have: patch-sstu-srb-a-realplume.cfg ?

It is likely causing the issues you are seeing. That is not one of my files, and I cannot provide support while it is potentially causing the very problems to be investigated....

al2me6 commented 4 years ago

Apologies, that was my own attempt at transplanting a RealPlume to SRB-A, as I didn't find a RealPlume patch for it in the SSTU folders. I guessed that the lack of a patch might have been the problem, but adding it didn't do anything (well, the plume itself did show up, but the bug persisted).

Here is a log with the patch removed: https://gist.github.com/al2me6/79817e2b6ce4af74fced7600d5bff78c

shadowmage45 commented 4 years ago

Thanks -- it seems like your log uploads are being truncated however, stopping around like ~9000, long before any of the real juicy bits (hasn't even started ModuleManager patching at that point).

Could you try uploading the full file to dropbox/etc, or somehow checking to make sure it is not truncated?

Specifically, I need to see all of the lines of where it is doing the part-compiling, as well as the lines that are written when in the flight scene and trying to use the particles.

For reference, the SSTU-realplume patch is all located here: https://github.com/shadowmage45/SSTULabs/blob/master/GameData/SSTU/ModIntegration/RealPlume/RealPlumes-ShipCore.cfg

You are not the only one reporting issues with RealPlume, so I have to believe there is some sort of error. However, I'm not seeing any issues on my install, so this might take a bit of time to track down.

al2me6 commented 4 years ago

You can click "view full file" to see the entire log. Link here: https://gist.githubusercontent.com/al2me6/79817e2b6ce4af74fced7600d5bff78c/raw/96710595969da60c6d6cb48aed7d575ddbfc3e09/KSP-rp-crp-nopatch.log

Edit: ah, yes. This explains why I didn't find the patch in RealPlume-Engines.cfg.

shadowmage45 commented 4 years ago

Doh, my bad, I should know that :)

Anyway, I'm finding lots of these in the log:

[EXC 16:46:11.272] NullReferenceException: Object reference not set to an instance of an object
    ModelMultiShurikenPersistFX.GetEffectConfig () (at <e2bd9712477342268a63f73f01aa06c1>:0)
    ModelMultiShurikenPersistFX.OnLoad (ConfigNode node) (at <e2bd9712477342268a63f73f01aa06c1>:0)
    EffectList.LoadEffect (ConfigNode node) (at <9d71e4043e394d78a6cf9193ad011698>:0)
    EffectList.OnLoad (ConfigNode node) (at <9d71e4043e394d78a6cf9193ad011698>:0)
    SSTUTools.SSTUModularPart.updateEffectsScale () (at <6d6016fa26f74e14add07756e2c33927>:0)
    SSTUTools.SSTUModularPart.updateEngineModule () (at <6d6016fa26f74e14add07756e2c33927>:0)
    SSTUTools.SSTUModularPart+<>c.<initializeUI>b__170_0 (SSTUTools.SSTUModularPart m) (at <6d6016fa26f74e14add07756e2c33927>:0)
    SSTUTools.SSTUModularPart+<>c__DisplayClass170_1.<initializeUI>b__23 (SSTUTools.SSTUModularPart m) (at <6d6016fa26f74e14add07756e2c33927>:0)
    SSTUTools.SSTUExtensions.actionWithSymmetry[T] (T module, System.Action`1[T] action) (at <6d6016fa26f74e14add07756e2c33927>:0)
    SSTUTools.SSTUModularPart+<>c__DisplayClass170_0.<initializeUI>b__2 (BaseField a, System.Object b) (at <6d6016fa26f74e14add07756e2c33927>:0)
    UIPartActionFieldItem.SetFieldValue (System.Object newValue) (at <9d71e4043e394d78a6cf9193ad011698>:0)
    UIPartActionChooseOption.SetFieldValue (System.Int32 index) (at <9d71e4043e394d78a6cf9193ad011698>:0)
    UIPartActionChooseOption.UpdateState (System.Int32 dir, KSP.UI.UIButtonToggle button) (at <9d71e4043e394d78a6cf9193ad011698>:0)
    UIPartActionChooseOption.OnTap_inc () (at <9d71e4043e394d78a6cf9193ad011698>:0)
    UnityEngine.Events.InvokableCall.Invoke () (at <5aeafee3fea24f37abd1315553f2cfa6>:0)
    UnityEngine.Events.UnityEvent.Invoke () (at <5aeafee3fea24f37abd1315553f2cfa6>:0)
    KSP.UI.UIButtonToggle.OnClick () (at <9d71e4043e394d78a6cf9193ad011698>:0)
    UnityEngine.Events.InvokableCall.Invoke () (at <5aeafee3fea24f37abd1315553f2cfa6>:0)
    UnityEngine.Events.UnityEvent.Invoke () (at <5aeafee3fea24f37abd1315553f2cfa6>:0)
    UnityEngine.UI.Button.Press () (at <22fd67f59718453e9250a6de1843ef8b>:0)
    UnityEngine.UI.Button.OnPointerClick (UnityEngine.EventSystems.PointerEventData eventData) (at <22fd67f59718453e9250a6de1843ef8b>:0)
    UnityEngine.EventSystems.ExecuteEvents.Execute (UnityEngine.EventSystems.IPointerClickHandler handler, UnityEngine.EventSystems.BaseEventData eventData) (at <22fd67f59718453e9250a6de1843ef8b>:0)
    UnityEngine.EventSystems.ExecuteEvents.Execute[T] (UnityEngine.GameObject target, UnityEngine.EventSystems.BaseEventData eventData, UnityEngine.EventSystems.ExecuteEvents+EventFunction`1[T1] functor) (at <22fd67f59718453e9250a6de1843ef8b>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.EventSystems.EventSystem:Update()

Which basically means that RealPlume is not finding the plume config that was specified.

Taking a quick look to see if I can reproduce locally; I know there were some issues with a recent version of SmokeScreen that was causing issues like this, but cannot say if that is this problem.

shadowmage45 commented 4 years ago

Strangely, I'm not seeing this problem myself, using copies of the latest versions of RealPlume ( https://github.com/KSP-RO/RealPlume/releases/download/v13.1.0/RealPlume_v13.1.0.zip ) and Smokescreen ( https://ksp.sarbian.com/jenkins/job/SmokeScreen/86/artifact/SmokeScreen-2.8.13.0.zip )

screenshot40 (SRB-A, using RealPlume; KSP 1.8.x, with latest versions of TU and SSTU)

The one commonality that I'm seeing between your install and the others reporting issues with RealPlume is the 'RealPlume-Stock' folder.

Could you try removing that folder/mod, and see if the problem persists?

al2me6 commented 4 years ago

The NREs are only triggered by attempting to change the configuration of the SRB. On my install, the default configurations work fine, and the plume does show (and could be changed by myself).

AFAIK, RealPlume-Stock does not contain patches for SSTU. But I'll verify once I have access to my KSP install.

shadowmage45 commented 4 years ago

The NREs are only triggered by attempting to change the configuration of the SRB. On my install, the default configurations work fine, and the plume does show (and could be changed by myself).

Ahh, that would make sense (as to why I didn't see it). I merely took a pod, added SRB, and launched (was checking plumes specifically).

I'll do some further testing with adjustments to the SRB size/length/etc.

AkiraR commented 3 years ago

Was able to reproduce with just SSTU, RealPlume and dependencies, no RealPlume-stock. -create vehicle with just a pod and an SSTU SRB -change core size and note that SolidFuel value does not change and NREs appear in log

https://gist.github.com/AkiraR/e2316a6878d169cefdb3eb0e1813f3d5

EDIT: -Just as an FYI to maybe save you some time. I did a bunch of messing around with patch order just to see if some thing was getting screwed up, I got to thew point where I entirely nixed the RealPlume patching method and just wrote a :FINAL patch that pulls the stock effects and adds the particles unlocked by smokescreen and still had the issue,