shaise / FreeCAD_SheetMetal

A simple sheet metal workbench for FreeCAD
http://theseger.com/projects/2015/06/sheet-metal-addon-for-freecad/
GNU Lesser General Public License v2.1
190 stars 55 forks source link

Overhaul sheet metal icons to be consistent with FreeCAD #313

Closed maxwxyz closed 5 months ago

maxwxyz commented 5 months ago

PR with recreated icons to be consistent in the SheetMetal WB and across the FreeCAD application according to the Artwork Guidelines There are also some alternative versions included and some specific feature icons for the following DWG proposal. @shaise just let me know if in need for further icons in the future.

Current icons: grafik

New icons: grafik

In FreeCAD: grafik

Feedback is appreciated. If you don't like the green to indicate the feature/position it could be made all blue as well.

shaise commented 5 months ago

Hi @maxwxyz, Wow! These icons are absolutely phenomenal. Here are some changes I would like if it is OK with you: for SheetMetal_AddBend, I prefer something like this: image

For SheetMetal-AddRelief : image

And for for SheetMetal-AddBaseShape I prefer upside down like this orientation: image

All others are great, and also the first selection (non alt) is ok Thanks!

maxwxyz commented 5 months ago

@shaise I'm on it. Add bend: is this how its supposed to work? The backside gets no bend radius. grafik

maxwxyz commented 5 months ago

@shaise done grafik

shaise commented 5 months ago

Great! thanks!

shaise commented 5 months ago

Ah, and sorry, for your question about the bend: image

when you manually set the correct width of the wall, this should have converted to a real bend, similar to the icon, however there seem to be a bug there, I need to take a look.

shaise commented 5 months ago

Hi @maxwxyz , OK. I have rewritten the entire bend function. It is now more robust, and it also detects the thickness automatically. Please update and try the example you tested to see if it is ok now.

maxwxyz commented 5 months ago

Nice

shaise commented 5 months ago

Thanks again for the icons. they are awesome.