Closed maxwxyz closed 5 months ago
Hi @maxwxyz,
Wow! These icons are absolutely phenomenal.
Here are some changes I would like if it is OK with you:
for SheetMetal_AddBend, I prefer something like this:
For SheetMetal-AddRelief :
And for for SheetMetal-AddBaseShape I prefer upside down like this orientation:
All others are great, and also the first selection (non alt) is ok Thanks!
@shaise I'm on it.
Add bend: is this how its supposed to work? The backside gets no bend radius.
@shaise done
Great! thanks!
Ah, and sorry, for your question about the bend:
when you manually set the correct width of the wall, this should have converted to a real bend, similar to the icon, however there seem to be a bug there, I need to take a look.
Hi @maxwxyz , OK. I have rewritten the entire bend function. It is now more robust, and it also detects the thickness automatically. Please update and try the example you tested to see if it is ok now.
Nice
Thanks again for the icons. they are awesome.
PR with recreated icons to be consistent in the SheetMetal WB and across the FreeCAD application according to the Artwork Guidelines There are also some alternative versions included and some specific feature icons for the following DWG proposal. @shaise just let me know if in need for further icons in the future.
Current icons:![grafik](https://github.com/shaise/FreeCAD_SheetMetal/assets/6246609/7063aabc-3f84-4454-b5da-bafc1c1d95b8)
New icons:![grafik](https://github.com/shaise/FreeCAD_SheetMetal/assets/6246609/085a5333-4fd6-496a-a1bd-2723e50f9b54)
In FreeCAD:![grafik](https://github.com/shaise/FreeCAD_SheetMetal/assets/6246609/115a764d-eec6-4247-b082-190b733006a3)
Feedback is appreciated. If you don't like the green to indicate the feature/position it could be made all blue as well.