search

shaise / FreeCAD_SheetMetal

A simple sheet metal workbench for FreeCAD
http://theseger.com/projects/2015/06/sheet-metal-addon-for-freecad/
GNU Lesser General Public License v2.1
205 stars 58 forks source link

The hole disappears at the bend. #363

Closed free777cat closed 2 months ago

free777cat commented 3 months ago

The hole disappears at the bend.

The hole disappears at the bend if the diameter is less than the length of the sweep and the hole does not extend beyond the edge of the bend.

https://youtu.be/5vku80OS9XQ

shaise commented 2 months ago

Yes this is a tough one. not sure if its an easy fix. @jaisekjames any ideas?

free777cat commented 2 months ago

I experimented a little. SheetMetalBendSolid.py def wrap_face(face, radius, axis, normal, zero_vert, center, zero_vert_normal): The idea: to make a solid without bending (flat) using a similar method, subtract the solid of the middle part that already exists with a Boolean operation. The result of the operation will be inverted holes (solid).

Bend two solids separately using the def wrap_face method.

Boolean operation: subtract the solid of the holes (bent from bent)

shaise commented 2 months ago

@free777cat , thanks to @jaisekjames this should be fixed now. Please test and close the issue if works. image

free777cat commented 2 months ago

Thank you!

Зняток екрана як 2024-09-09 18-11-45

free777cat commented 2 months ago

Now it is impossible to unfold Зняток екрана як 2024-09-10 10-53-17 ex2_.zip

free777cat commented 2 months ago

It may even be so... ex1_.zip

shaise commented 2 months ago

@free777cat , this is a different issue. Unfolding with holes in the bend did not work even before the current issue was fixed. I think this should be closed and a separate issue open for the unfolder. Mind, though, that this might take time since the unfold feature coder is not active.