search

shaise / FreeCAD_SheetMetal

A simple sheet metal workbench for FreeCAD
http://theseger.com/projects/2015/06/sheet-metal-addon-for-freecad/
GNU Lesser General Public License v2.1
205 stars 58 forks source link

Bend perforation. Errors #372

Closed free777cat closed 2 months ago

free777cat commented 2 months ago

  1. Perforation Angle = it is possible to enter a negative value

  2. Perforation Initial Length = a null value cannot be entered !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

  3. Is it still possible to add a perforation width parameter related to the Perforation Angle? Changing one parameter recalculates the other and vice versa. It is important when we use stamping with a tool of a certain size.

shaise commented 2 months ago

@Erhannis , can you comment on that?

free777cat commented 2 months ago

Perforation Angle =0

maybe it should start from 90 degrees?

shaise commented 2 months ago

maybe it should start from 90 degrees?

I'm actually OK with that. 0 means the perforation adapts to the bend angle.

free777cat commented 2 months ago

Then it would be a good idea to display the value of the angle. It will immediately be intuitively clear where it comes from.

shaise commented 2 months ago

When it will have a special task panel for that it will be possible.

Erhannis commented 2 months ago
  1. Negative angle - I don't know whether or not that can be prevented with FreeCAD the way it is. Somebody else with more FreeCAD programming experience would be better suited to answer that. At the moment, it seems a negative angle just defaults to the same angle as the bend, which seems to me like reasonable behavior. Taking the absolute value of the angle would also be a reasonable behavior, possibly more desirable.
  2. Zero, you mean? Oh, you're right. Here's a fix: https://github.com/shaise/FreeCAD_SheetMetal/pull/374
  3. Parameter dependencies - well, you could set both to formulas referencing a single cell in a spreadsheet, so they'd both update when you updated the spreadsheet. I don't know whether or not FreeCAD directly supports linking two parameters bidirectionally; somebody else may know better.
free777cat commented 2 months ago

Thank you!

I am generally against the use of spreadsheets.

Erhannis commented 2 months ago

against spreadsheets

Oh? I suppose that's allowed, haha, but I'm personally curious why that is.

free777cat commented 2 months ago

In more complex projects, this is absolute horror!!! If you correctly connect the dimensions of the parts on the sketches, you can always clearly and quickly find the original data.

Erhannis commented 2 months ago

Huh, ok; good to know