search

shaise / FreeCAD_SheetMetal

A simple sheet metal workbench for FreeCAD
http://theseger.com/projects/2015/06/sheet-metal-addon-for-freecad/
GNU Lesser General Public License v2.1
204 stars 58 forks source link

Add missing error codes to `SheetMetalUnfolder.py` #98

Open luzpaz opened 5 years ago

luzpaz commented 5 years ago

There are certain places in the SheetMetalUnfolder.py that are missing error codes.

https://github.com/shaise/FreeCAD_SheetMetal/blob/9bf7bac659b02aa9b5e920f74d70ac53e1d8cd01/SheetMetalUnfolder.py#L131-L133

https://github.com/shaise/FreeCAD_SheetMetal/blob/9bf7bac659b02aa9b5e920f74d70ac53e1d8cd01/SheetMetalUnfolder.py#L1859-L1860

https://github.com/shaise/FreeCAD_SheetMetal/blob/9bf7bac659b02aa9b5e920f74d70ac53e1d8cd01/SheetMetalUnfolder.py#L1510-L1513

https://github.com/shaise/FreeCAD_SheetMetal/blob/9bf7bac659b02aa9b5e920f74d70ac53e1d8cd01/SheetMetalUnfolder.py#L783-L785

luzpaz commented 3 years ago

Looks like @matthewdickinson's PR #10 was trying to address this

luzpaz commented 3 years ago

@shaise was this actually realized?

shaise commented 3 years ago

No, the PR was conflicting

luzpaz commented 2 years ago

Updated ticket with hyperlinked references in to the code