search

shaka-project / shaka-packager

A media packaging and development framework for VOD and Live DASH and HLS applications, supporting Common Encryption for Widevine and other DRM Systems.
https://shaka-project.github.io/shaka-packager/
Other
2.01k stars 511 forks source link

feat: Add IAMF support (#1415) #1416

Closed felicialim closed 1 month ago

felicialim commented 3 months ago

BEGIN_COMMIT_OVERRIDE feat: Add IAMF support (#1416) Closes #1415 END_COMMIT_OVERRIDE

sr1990 commented 3 months ago

Please add an end-to-end test in src/packager/app/test/packager_test.py to create golden files for verifying the correctness of the generated codec strings in DASH and HLS manifest files.

felicialim commented 3 months ago

Please add an end-to-end test in src/packager/app/test/packager_test.py to create golden files for verifying the correctness of the generated codec strings in DASH and HLS manifest files.

Thanks for the pointer, done.

cosmin commented 1 month ago

@sr1990 does this seem good enough to merge for now and potentially refine later or do we have anything outstanding that must be addressed first?

sr1990 commented 1 month ago

@sr1990 does this seem good enough to merge for now and potentially refine later or do we have anything outstanding that must be addressed first?

@cosmin lgtm. Thanks @felicialim.