shaka-project / shaka-player-embedded

Shaka Player in a C++ Framework
Apache License 2.0
236 stars 63 forks source link

Split player and view functionalities #106

Closed jgongo closed 4 years ago

jgongo commented 4 years ago

In Shaka Player Embedded you have the resource loading, player and view functionalities implemented in a single class, ShakaPlayerView. This seems unnatural, as they are completely different responsibilities, and makes difficult to implement a clear separation between view and model in the app.

On iOS you have:

I don't know if such a separation is technically feasible in Shaka Player Embedded, but in case it is, could you please consider implementing at least the player and the view in separate classes?