search

shaka-project / shaka-player

JavaScript player library / DASH & HLS client / MSE-EME player
Apache License 2.0
7.22k stars 1.34k forks source link

Time ID3, emsg, and metadata events to the presentation timeline #7556

Open joeyparrish opened 2 weeks ago

joeyparrish commented 2 weeks ago

Have you read the FAQ and checked for duplicate open issues? No

Is your feature request related to a problem? Please describe.

ID3, emsg, and metadata events are fired as soon as the metadata is parsed. This can confuse ad SDKs and others interfacing to them.

Describe the solution you'd like

These events should be fired when we reach appropriate times in the presentation.

This could leverage TimelineRegion so that metadata events with a range of applicable times fire appropriately even when seeking.

Describe alternatives you've considered

Making everyone else cope with it so I can be lazy

Additional context

Internal discussion within Google at b/365662199

Are you planning send a PR to add it? Yes, though the work hasn't been scheduled yet

joeyparrish commented 2 weeks ago

Received this raw AAC ID3 stream from Alvaro for testing: https://cadena100-cope.flumotion.com/chunks.m3u8