Closed justin808 closed 9 years ago
This addresses issue: https://github.com/justin808/bootstrap-sass-loader/issues/9
Looks good to me! I am trying to find another alternative to adding another file vs trying to somehow encompass both into one.
I understand the use case and value of utilizing the defined variables in _variables.scss
hmmm
@mmahalwy Try it out thoroughly. I think this will be the change that takes this npm module v1.0!
Any improvements to the examples, readmes, etc. are greatly appreciated!
Hmmm.. I can't seem to get the glyphs working :(
// Needed for the css-loader when [bootstrap-webpack](https://github.com/bline/bootstrap-webpack)
// loads bootstrap's css.
{ test: /\.woff(\?v=\d+\.\d+\.\d+)?$/, loader: "url?limit=10000&minetype=application/font-woff" },
{ test: /\.woff2(\?v=\d+\.\d+\.\d+)?$/, loader: "url?limit=10000&minetype=application/font-woff" },
{ test: /\.ttf(\?v=\d+\.\d+\.\d+)?$/, loader: "url?limit=10000&minetype=application/octet-stream" },
{ test: /\.eot(\?v=\d+\.\d+\.\d+)?$/, loader: "file" },
{ test: /\.svg(\?v=\d+\.\d+\.\d+)?$/, loader: "url?limit=10000&minetype=image/svg+xml" }
This works though https://github.com/andreypopp/react-fa
@mmahalwy I don't think this issue on the glyphs is related to the main issue here.
Here's an example of configuration: https://github.com/justin808/bootstrap-sass-loader-example/blob/master/webpack.config.js
https://github.com/justin808/bootstrap-sass-loader-example/blob/master/bootstrap-sass.config.js
@justin808 right - good point.
Tested and works great! +1
Thanks a ton for making this happen - you're awesome!
@mmahalwy Please update your project to v 1.0.1 of the bootstrap-sass-loader.
Awesom! Thanks a ton! Congrats :)