search

shama / letswritecode

:mortar_board: code examples for Let's Write Code
https://www.youtube.com/user/kylerobinsonyoung
804 stars 759 forks source link

Electron apps outdated #3

Open Spriithy opened 9 years ago

Spriithy commented 9 years ago

Hey ! Just to let you know that your way of doing things with electron is already outdated ! There are imperative arguments to : electron-packager such as --platform=, --arch= and --version=.

That means, your source code doesn't compile anymore !

@TheophileDano

shama commented 9 years ago

Dang! I knew that would happen but didn't think so soon. Thanks for the heads up!

The good news is everything is versioned so the example here should hopefully still work. Please let me know if it doesn't.

Spriithy commented 9 years ago

You should have a look a TideSDK by the way. It is way easier to be honest. And thanks fort replying

Le ven. 5 juin 2015 18:15, Kyle Robinson Young notifications@github.com a écrit :

Dang! I knew that would happen but didn't think so soon. Thanks for the heads up!

The good news is everything is versioned so the example here https://github.com/shama/letswritecode/tree/master/packaging-distributing-electron-apps should hopefully still work. Please let me know if it doesn't.

— Reply to this email directly or view it on GitHub https://github.com/shama/letswritecode/issues/3#issuecomment-109347986.

shama commented 9 years ago

Ah interesting, thanks for letting know about TideSDK!

Spriithy commented 9 years ago

Haha if you ever need something about it let me know

Le sam. 6 juin 2015 02:00, Kyle Robinson Young notifications@github.com a écrit :

Ah interesting, thanks for letting know about TideSDK!

— Reply to this email directly or view it on GitHub https://github.com/shama/letswritecode/issues/3#issuecomment-109486185.

Spriithy commented 9 years ago

Well after a quick review of your code in this sample, this shouldn't work. I've just cloned it, try to run it using the new electron version. Well that's what i used to say, doesn't work ;)

shama commented 9 years ago

Thanks! I added an annotation to the video indicating that electron-packager >= 4.0.0 now requires the platform, arch, and version options.

Spriithy commented 9 years ago

Sounds great ! But I was wondering, when I type electron-packager ./ app_name --platform=darwin --arch=x86 --version=0.27.2, the app will just launch the Electron default app... I guess I'm doing it wrong.