search

shannon-lab / zapdos

Open source MOOSE framework application for simulating plasmas
https://shannon-lab.github.io/zapdos/
GNU Lesser General Public License v2.1
39 stars 38 forks source link

Removing unused BC #243

Closed gsgall closed 7 months ago

gsgall commented 7 months ago
moosebuild commented 7 months ago

Job Documentation on c5b7fbc wanted to post the following:

View the site here

This comment will be updated on new commits.

gsgall commented 7 months ago

Please perform a search for the object and remove it from the input files it appears in as well. I did this earlier, and they should be in the Schottky emission inputs, but commented out.

I removed the comments where this was in there from

gsgall commented 7 months ago

Just for my own knowledge is there a reason why we'd want to have extra input blocks commented out in test files. Is it just to show users other similar options?

cticenhour commented 7 months ago

I would normally not leave commented out blocks in, but I'm making an exception here because these inputs aren't fully tested - only syntax-checked. If they are ever fully tested (i.e., diffed), then we might need to know that an alternative currently-tested object was used for a particular case to help finalize the test.

One more thing that CI is saying we should do (because GitHub code suggestions can leave unintended whitespace). Please do what the precheck is telling us and fixup the last commit:

ERROR: The following files contain trailing whitespace after applying your patch:
    test/tests/1d_dc/NonlocalPotentialBCWithSchottky.i
    test/tests/Schottky_emission/Example4/Input.i
    test/tests/Schottky_emission/Example4/Jac.i

Run the "delete_trailing_whitespace.sh" script in your $MOOSE_DIR/scripts directory.
gsgall commented 7 months ago

that makes sense thank you for the explanation @cticenhour