[BUG] default colors have low visibility on light terminal themes - Githubissues

sharkdp / fd

A simple, fast and user-friendly alternative to 'find'

Apache License 2.0

34.25k stars 816 forks source link

[BUG] default colors have low visibility on light terminal themes #1635

Open tenturestept opened 3 weeks ago

tenturestept commented 3 weeks ago

Checks

[X] I have read the troubleshooting section and still think this is a bug.

Describe the bug you encountered:

the default colors are specified here:

https://github.com/sharkdp/fd/blob/71deea6671698e4074a6dd208d528e39831f1fb7/src/main.rs#L53-L56

this is what it looks like using the default terminal.app theme on the macOS:

example

most colors used don't have enough contrast to be readable.

Describe what you expected to happen:

i would expect more readable colors by default. this might require a simpler, but admittedly more boring ls_colors.

related: #1031, #1440

i have committed a possible solution to https://github.com/tenturestept/fd/tree/simplify-colors

What version of `fd` are you using?

10.2.0 (actually it's git master)

Which operating system / distribution are you on?

macos 14 sonoma

gnome on linux with the light theme also has this issue

the light theme on windows terminal also has this issue