search

sharkdp / insect

High precision scientific calculator with support for physical units
https://numbat.dev/
MIT License
3.17k stars 126 forks source link

Generate licenses of all dependencies #355

Closed triallax closed 1 year ago

triallax commented 1 year ago

Fixes https://github.com/sharkdp/insect/issues/324.

triallax commented 1 year ago

@sharkdp purescript-pairs, which you own, doesn't have a LICENSE file in its repo and so does not have a license attached to it in the generated license files. Could you please add one? There's https://github.com/purescript/purescript-numbers/issues/25 too, but I'll open a PR for that myself.

sharkdp commented 1 year ago

@sharkdp purescript-pairs, which you own, doesn't have a LICENSE file in its repo and so does not have a license attached to it in the generated license files. Could you please add one?

Done

triallax commented 1 year ago

Thank you for working on this!

Sure, you're welcome! This has been bugging me for quite a while, so I'm happy to be making progress on it now.

triallax commented 1 year ago

The last dependency without a license file is https://github.com/jcubic/lily (see https://github.com/jcubic/lily/issues/8), but I don't know if we should wait for the maintainer to add one, as this is an urgent PR. Do we just include special-case it and include the text in https://github.com/jcubic/lily#license for now?

triallax commented 1 year ago

@sharkdp could you please cut a new version of purescript-pairs? You haven't made one after you added the license file.

sharkdp commented 1 year ago

Done

sharkdp commented 1 year ago

Do we just include special-case it and include the text in https://github.com/jcubic/lily#license for now?

sounds good

triallax commented 1 year ago

Should be ready for review/merge now.

triallax commented 1 year ago

@sharkdp please release v5.8.1 on GitHub and npm and update the Insect website when you get the time.

sharkdp commented 1 year ago

Thank you. I released a new version to npm before checking the npm package somehow. It seems like it doesn't contain the third party licenses. Do we need to add that file to the "files" section in package.json?

triallax commented 1 year ago

Yeah, my bad, it should be. I'll open a PR for that real quick.

sharkdp commented 1 year ago

No worries, thank you very much for working on this!

triallax commented 1 year ago

You're welcome.

I guess this means we're going to need to publish a v5.8.2 now? Should we revoke v5.8.1 from npm?

sharkdp commented 1 year ago

I guess this means we're going to need to publish a v5.8.2 now?

Done.

Should we revoke v5.8.1 from npm?

I don't see a need for that.

triallax commented 1 year ago

Alright then.

I was impatient for a new release with this PR to be made so that I could try to package Insect for Void Linux. I'm going to work on that sometime in the near future. :)

triallax commented 1 year ago

Small update: before I got to work on packaging Insect, I asked on IRC and unfortunately the Void Linux team said they wouldn't accept it, but at least I saved some effort.

sharkdp commented 1 year ago

Thank you for the feedback. Any concrete reasons?

triallax commented 1 year ago

https://github.com/void-linux/void-packages/issues/11628#issuecomment-1471699418

sharkdp commented 1 year ago

One possible reason that would be in favor of providing a distribution package over npm: it allows proper installation of things like man pages, desktop files, etc.

triallax commented 1 year ago

I don't think that's going to convince them, but having Insect be rewritten in a certain compiled language might. :)