Complete quoting for parameters of some CMake commands

shashlik / old-shashlik

Android Simulated Environment

326 stars 23 forks source link

Complete quoting for parameters of some CMake commands #26

Open elfring opened 9 years ago

elfring commented 9 years ago

Some parameters (like "${ANDROID_CORE_PATH}/include" and "${ANDROID_LIB_DIR}/hw") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.

I would recommend to apply advices from a wiki article.

leinir commented 9 years ago

Well spotted, yes, these certainly are an issue.