shawnlaffan / biodiverse

A tool for the spatial analysis of diversity
http://shawnlaffan.github.io/biodiverse/
GNU General Public License v3.0
75 stars 19 forks source link

Spatial - allow user control of spatial index and recycling per analysis #205

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.  Run a spatial analysis with a condition like '$nbr_y > 3050000'.

What is the expected output? What do you see instead?
All processing groups should have neighbours consisting of all groups north of 
coordinate 3050000.  Instead, the neighbours differ by processing group.  This 
is caused by the spatial index.

The workaround is to turn off the spatial index before running it.

Original issue reported on code.google.com by shawnlaffan on 18 Jan 2011 at 10:37

GoogleCodeExporter commented 9 years ago
This is related to issue #305

Original comment by shawnlaffan on 14 Nov 2013 at 4:37

GoogleCodeExporter commented 9 years ago

Original comment by shawnlaffan on 16 Nov 2013 at 9:36

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r3033.

Create branch to work on this issue

Original comment by shawnlaffan on 16 Nov 2014 at 5:14

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r3035.

Add an options dialogue to the spatial conditions.  Does not propagate to 
callers yet.  

Original comment by shawnlaffan on 18 Nov 2014 at 3:13

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r3036.

Copy across edits from issue 305 where we control the recycling at an overall 
level.  

Original comment by shawnlaffan on 23 Nov 2014 at 10:40

GoogleCodeExporter commented 9 years ago
Issue 305 has been merged into this issue.

Original comment by shawnlaffan on 23 Nov 2014 at 10:41

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r3037.

Merge latest trunk revisions across to the branch

Original comment by shawnlaffan on 23 Nov 2014 at 10:44

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r3038.

Clean up the BaseStruct list assignment process.  It had not been touched in a 
very long time.  

Original comment by shawnlaffan on 24 Nov 2014 at 2:23

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r3039.

Add no_recycle method to the spatial conditions objects.  Use this in the 
spatial analyses.  
Add tests for recycling.  This has flushed out a few bugs with the processing 
of neighbour lists.  

Original comment by shawnlaffan on 24 Nov 2014 at 2:24

GoogleCodeExporter commented 9 years ago
Options to control at the analysis output level:
1.  recycling of results from other spatial analyses, and
2.  recycling of results and neighbour sets at the analysis level.

Original comment by shawnlaffan on 24 Nov 2014 at 4:54

GoogleCodeExporter commented 9 years ago

Original comment by shawnlaffan on 24 Nov 2014 at 4:54

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r3042.

Test cleanup to reduce boiler plate code. 

Original comment by shawnlaffan on 24 Nov 2014 at 5:13

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r3043.

Add a flag to ignore the spatial index. 

Original comment by shawnlaffan on 24 Nov 2014 at 5:14

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r3044.

Use keyword args for GUI::SpatialParams->new.
Add tooltips for the settings, and use settings from pre-existing objects if 
available. 
Clean up the conditions handling in GUI::Spatial and GUI::Cluster while we're 
about it.  

Original comment by shawnlaffan on 24 Nov 2014 at 5:23

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r3045.

Biodiverse::Spatial now processes the per-condition ignore_index flags.
Still need to handle a global flag.

Original comment by shawnlaffan on 24 Nov 2014 at 6:05

GoogleCodeExporter commented 9 years ago
Change issue title to match contents

Original comment by shawnlaffan on 24 Nov 2014 at 9:00

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r3046.

Add global options to the spatial tab.

Original comment by shawnlaffan on 24 Nov 2014 at 10:30

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r3050.

Merge revisions across to the trunk.  

Original comment by shawnlaffan on 25 Nov 2014 at 2:01

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r3051.

Delete branches associated with this issue (205 & 305 since the latter issue 
was merged into this one)

Original comment by shawnlaffan on 25 Nov 2014 at 2:05

GoogleCodeExporter commented 9 years ago
Mark as fixed

Original comment by shawnlaffan on 25 Nov 2014 at 8:58

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r3068.

Neglected to update one call to SpatialParams->new now it uses hash args.  

Original comment by shawnlaffan on 28 Nov 2014 at 12:41