search

sheilasaia / paper-ndfd-nccoast-study

Analysis associated with ndfd shellcast paper.
1 stars 0 forks source link

lag 48h and 72h ndfd forecast values #15

Open nataliegnelson opened 3 years ago

nataliegnelson commented 3 years ago

Currently, the qpf and pop values for the 48h and 72h valid periods are lined up with the 24h observed rainfall values (e.g., a 48h forecast issued on Jan 1 is being compared to actual precip from Jan 1, but should be compared to actual precip from Jan 2). New date columns should be added that correspond to the different ndfd valid periods, and the data should then be reorganized to ensure the observed precip values are aligned with the appropriate forecast valid periods.

To implement this change, edit the roc_wrangle_data_script.R script. From discussion today, it seems like a good approach would be to add columns for date_48h and date_72h when creating temp_ndfd_data_sel (line 307). The data would still need to be realigned so the precip matches the forecast valid periods (maybe done after the completion of the i/j/k loops?).

sheilasaia commented 3 years ago

@nataliegnelson I've finished doing this from the beginning of the analysis and am at the step of using it in the AGU analysis (ROC analysis is after that). I've yet to upload all these data to this repo but plan to do that in one big push when we're ready to publish (the data folder is in the gitignore currently). Would you like me to update the shellcast analysis repo on the NC State GitHub with this info as well? I don't want to mess up you and Eshwar's work on the ML model so let me know!

sheilasaia commented 3 years ago

@nataliegnelson did this on my analysis end but at some point we need to meet to make sure random forest model is using the same data for inputs.