search

shekharramola / react-wheel-of-prizes

It is a wheel of prizes game for react developers
89 stars 58 forks source link

Typescript Issue #18

Open mountainfresh opened 2 years ago

mountainfresh commented 2 years ago

Please consider exporting a .d.ts file with the package for people who use typescript. I am getting this error and having a type declaration file would make it much easier to deal with :) Thanks! Could not find a declaration file for module 'react-wheel-of-prizes'. .../node_modules/react-wheel-of-prizes/dist/index.js' implicitly has an 'any' type. Try npm i --save-dev @types/react-wheel-of-prizes if it exists or add a new declaration (.d.ts) file containing declare module 'react-wheel-of-prizes';

RyanMan56 commented 1 year ago

@mountainfresh @shekharramola Copying my comment from another thread... I've converted this project locally into modern typescript usable with React 18 (and have fixed a couple of small bugs on the way), I can make a PR to merge those changes into this project if there's still demand

sandymcfadden commented 9 months ago

I personally think it would be great if you did @RyanMan56 even if it doesn't get merged I would use it in my project as well.

RyanMan56 commented 9 months ago

I personally think it would be great if you did @RyanMan56 even if it doesn't get merged I would use it in my project as well.

Cool I'll raise a PR in the next couple of days :)

maciekmp commented 2 months ago

good work! :)