shekharramola / react-wheel-of-prizes

It is a wheel of prizes game for react developers
89 stars 58 forks source link

Dependancies prevent use on react 17 or 18 #21

Open f4hy opened 2 years ago

f4hy commented 2 years ago

Currently the dependency only allows use of react 16. React 17 and 18 are both out as of now.

SebTheRed commented 1 year ago

Just ran into this error myself. Is this something simple to do? I would like to help the dev update. LMK @shekharramola

RyanMan56 commented 1 year ago

@shekharramola @f4hy @SebTheRed I've converted this project locally into modern typescript usable with React 18 (and have fixed a couple of small bugs on the way), I can make a PR to merge those changes into this project if there's still demand

shekharramola commented 1 year ago

@RyanMan56 , Yes, please. that could help many people here.

doubledeckwa commented 6 months ago

@RyanMan56 HI, you can send a pull request ? You're just gonna save my life.

RyanMan56 commented 6 months ago

@RyanMan56 HI, you can send a pull request ? You're just gonna save my life.

Good timing, you've caught me on my week off :) I'll raise the PR within the next couple of hours

RyanMan56 commented 6 months ago

@doubledeckwa I've tried running the latest master branch of this repo in a fresh Vite project running on React v18.2.0 and it seems to work fine now. And the other issues I mentioned have already been tackled.

But I have raised a PR adding TypeScript support and optional fontSize and outlineWidth props: https://github.com/shekharramola/react-wheel-of-prizes/pull/30

@shekharramola Please review when you get a chance

vatsal-crescentek commented 5 months ago

@RyanMan56 I am facing issue in running this package with react ^18.2.0. can you please how you ran it in your local machine with master branch. I tried to install it directly using npm i react-wheel-of-prizes

I tried using following commands

npm i https://github.com/shekharramola/react-wheel-of-prizes#master

npm i git+https://github.com/shekharramola/react-wheel-of-prizes.git#master

image