search

shell-pool / shpool

Think tmux, then aim... lower
Apache License 2.0
1.15k stars 20 forks source link

shpool not setting kernel window size struct completely #13

Closed willangley closed 4 months ago

willangley commented 4 months ago

I noticed a panic with a kitty terminal mouse interaction running under shpool, and reported it as a kitty bug (kovidgoyal/kitty#7405). kitty's author investigated, and said:

This is a bug in shpool it is not setting the full window size struct (the latter two pixel size fields to be precise) to the kernel via TIOCWINSZ for tty's it creates.

That said, I will fix the kitten to at least not panic, though mouse interactions will not work.

Originally posted by @kovidgoyal in https://github.com/kovidgoyal/kitty/issues/7405#issuecomment-2087946713

Can you update shpool to do this?

ethanpailes commented 4 months ago

Thanks for the report, I'll look into fixing this.

ethanpailes commented 4 months ago

@willangley I just merged a fix. You can see if it works out for you by building shpool from source

ethanpailes commented 4 months ago

I went through the reproduction steps with the patch applied and it no longer crashes kitty 0.32.1-1 (the version of the debian package I got kitty from)