search

shell-pool / shpool

Think tmux, then aim... lower
Apache License 2.0
1.15k stars 20 forks source link

libpam0g-dev is required #42

Closed daamien closed 3 months ago

daamien commented 3 months ago

Version info

Ubuntu 22.04 shpool v0.6.2

Logs


error: failed to run custom build command for `motd v0.2.1`                                                          

Caused by:                                                                                                           
  process didn't exit successfully: `/tmp/cargo-installfLaNPd/release/build/motd-0e127c12db4c87b5/build-script-build`(exit status: 101)                                                                                                   
  --- stdout                                                                                                         
  cargo:rerun-if-changed=src/pam_motd_overlay.c                                                                      
  cargo:rerun-if-changed=src/pam_motd_overlay_versions.ldscript                                                      

  --- stderr                                                                                                         
  thread 'main' panicked at /home/damien/.cargo/registry/src/index.crates.io-6f17d22bba15001f/motd-0.2.1/build.rs:23:3:                                                                                                                   
  build failed: error building overlay, code = exit status: 1                                                        
  STDOUT:                                                                                                            
  STDERR: ./src/pam_motd_overlay.c:11:10: fatal error: security/_pam_types.h: No such file or directory              
     11 | #include <security/_pam_types.h>                                                                           
        |          ^~~~~~~~~~~~~~~~~~~~~~~                                                                           
  compilation terminated.                                                                                            

  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace                                      
warning: build failed, waiting for other jobs to finish...                                                           
error: failed to compile `shpool v0.6.2`, intermediate artifacts can be found at `/tmp/cargo-installfLaNPd`.         
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

Solution

sudo apt-get install libpam0g-dev

ethanpailes commented 3 months ago

Thanks. I think this is a bug in the motd crate. We shouldn't be requiring this because we disable default features in order to use the pure-rust version of motd. We should not depend on libpam if we are using the pure rust version of the motd crate.

ethanpailes commented 3 months ago

https://github.com/shell-pool/motd/pull/9 will fix this once I cut a new motd release and bump the version shpool depends on.