shellscape / Gmail-Notifier-Plus

Gmail Notifier Plus
http://shellscape.org
MIT License
90 stars 26 forks source link

Null Reference Exception opening Preferences #138

Closed deathau closed 7 years ago

deathau commented 8 years ago

After installing Gmail Notifier Plus 3.7, I tell it to open automatically, and I get the following error window. Also happens when I try to open Preferences from the jump list. I can't register an account and the app is useless to me at the moment.

Windows 10 Pro (Post anniversary update), 64-bit.

If you need any more information, let me know. I can see that some others have posted similar issues but weren't able to provide details.

Copied error details below:

[Window Title] Gmail Notifier Plus Error

[Main Instruction] An unhandled exception occurred:

[Content] Error ID: 68de63db-bcbc-4826-a77b-3342bb735587

Object reference not set to an instance of an object.

[Expanded Information]

Server stack trace: at System.Windows.Forms.Control.MarshaledInvoke(Control caller, Delegate method, Object[] args, Boolean synchronous) at System.Windows.Forms.Control.Invoke(Delegate method, Object[] args) at Shellscape.Remoting.RemotingSingleton.Run(String[] arguments) at System.Runtime.Remoting.Messaging.StackBuilderSink._PrivateProcessMessage(IntPtr md, Object[] args, Object server, Object[]& outArgs) at System.Runtime.Remoting.Messaging.StackBuilderSink.SyncProcessMessage(IMessage msg)

Exception rethrown at [0]: at System.Runtime.Remoting.Proxies.RealProxy.HandleReturnMessage(IMessage reqMsg, IMessage retMsg) at System.Runtime.Remoting.Proxies.RealProxy.PrivateInvoke(MessageData& msgData, Int32 type) at Shellscape.Remoting.RemotingSingleton.Run(String[] arguments) at Shellscape.Program.CallRunningInstance(String[] arguments)

[V] See details [OK]

[Footer] Press CTL + C to copy this error to the clipboard.

shellscape commented 8 years ago

hey there. thanks for taking the time to file the report. I haven't used windows in years, so I don't actively maintain the app. @jansokoly was the last person to actively maintain GNP, and his last commit was 2 years ago. I'd welcome a pull request to fix your error, but beyond that it may not get fixed.

jansokoly commented 8 years ago

I'll look into it. I can confirm trying to open Preferences from the jump list results in the error described above.

deathau commented 8 years ago

Thanks for taking a look into it. In case it helps and you haven't found out already, I downloaded the source and it looks like the problem is a resource from authui.dll doesn't exist anymore Preferences.cs L232. I guess it should just be a matter of finding a replacement and bundling it with the app?

dmitry-lipetsk commented 8 years ago

Workaround: find the authui.dll [32bit, 10.0.10586.494] and copy it to "Gmail Notifier Plus" folder.

shellscape commented 8 years ago

When I put that dialog together (back on Windows 7, when Windows 7 was newish) I tried to use as many core resources from Windows as possible. This was to avoid the mishmash of custom dialogs that nearly every Windows app at the time went with. Given that there's been two Windows versions since version 7, that dialog may need an update to get with the times. Not sure if bundling authui.dll with the app is a wise choice across windows versions. But that's a solid workaround in the mean time @dmitry-lipetsk, thanks.

herringgas commented 7 years ago

I can also confirm that the fix @dmitry-lipetsk worked for me as well. One difference in my case is used the version of authui.dll (32bit, 6.1.7601.23537) from a Windows 7 system and placed it in the "C:\Users\Owner\AppData\Local\Shellscape\Gmail Notifier Plus\Gmail folder.

@jansokoly would this being something you would be willing to fix for a donation?

jansokoly commented 7 years ago

This is now fixed in master and will be released as part of version 3.8.

jansokoly commented 7 years ago

So, 3.8 is out. The built-in update mechanism will prompt you. Let me know if it fixes the issue for you.

shellscape commented 7 years ago

I'll update shellscape.org. Cheers