search

shenango / caladan

Interference-aware CPU scheduling that enables performance isolation and high CPU utilization for datacenter servers
Apache License 2.0
117 stars 50 forks source link

Potental stack allocation bug #14

Closed YangZhou1997 closed 1 year ago

YangZhou1997 commented 1 year ago

Hi Caladan authors!

I just tried to print out each uthread's stack address and find they are generally 0x7ffff... However, based on the variable of STACK_BASE_ADDR, stack address should start from 0x2000... Then I find this line actually calls atomic64_fetchandand() instead of atomic64_fetchandadd(). So it seems this is a small typo?

Just want to let you know about this potential bug, although the runtime works perfectly without fixing it!

Best, Yang

joshuafried commented 1 year ago

Thanks for pointing this out! We will remove the stack address hint code since we don't really need it.