search

sherlock-audit / 2022-10-astaria-judging

6 stars 1 forks source link

ak1 - Astaria protocol will miss the ERC1155 based NFT tokens #290

Closed sherlock-admin closed 2 years ago

sherlock-admin commented 2 years ago

ak1

medium

Astaria protocol will miss the ERC1155 based NFT tokens

Summary

This can be consider either medium or QA. But I want to notify that the current implementation does not consider the ERC1155 based NFT tokens for NFT based lending.

Vulnerability Detail

If the NFT token is ERC1155 based, Astaira will not provide the NFT based lending.

Impact

Astaira will miss out the ERC1155 based NFT tokens.

Code Snippet

https://github.com/AstariaXYZ/astaria-gpl/blob/64acee1122a71b23eef037f69cef4c0c087241be/src/ERC721.sol#L126-L131

Tool used

Manual Review

Recommendation

Implement to support ERC1155 based NFT as well.

https://eips.ethereum.org/EIPS/eip-1155