search

sherlock-audit / 2022-10-mover-judging

1 stars 0 forks source link

GalloDaSballo - L-01 Extra value will be lost #47

Closed sherlock-admin closed 2 years ago

sherlock-admin commented 2 years ago

GalloDaSballo

low

L-01 Extra value will be lost

Summary

https://github.com/sherlock-audit/2022-10-mover/blob/main/cardtopup_contract/contracts/ExchangeProxy.sol#L168-L169

        require(msg.value >= ethValue, "insufficient ETH provided");

Best to check for exact matching to avoid needless costs due to user mistakes

Vulnerability Detail

Impact

Code Snippet

Tool used

Manual Review

Recommendation

Change the >= to an ==