Closed sherlock-admin closed 1 year ago
ArbitraryExecution
medium
The initialize function takes a named argument, _protocolFee which shadows the protocolFee variable in ProtocolFee.sol
initialize
_protocolFee
protocolFee
ProtocolFee.sol
The TellerV2.sol contract inherits from ProtocolFee.
TellerV2.sol
ProtocolFee
None. This is bad coding practice and could lead to errors in the future.
import "./ProtocolFee.sol"; ... function initialize( uint16 _protocolFee, ... )
Manual Review
Rename _protocolFee in the initialize function.
ArbitraryExecution
medium
Shadowed variable
Summary
The
initialize
function takes a named argument,_protocolFee
which shadows theprotocolFee
variable inProtocolFee.sol
Vulnerability Detail
The
TellerV2.sol
contract inherits fromProtocolFee
.Impact
None. This is bad coding practice and could lead to errors in the future.
Code Snippet
Tool used
Manual Review
Recommendation
Rename
_protocolFee
in theinitialize
function.