sherlock-audit / 2023-03-teller-judging

8 stars 6 forks source link

ArbitraryExecution - Shadowed variable #483

Closed sherlock-admin closed 1 year ago

sherlock-admin commented 1 year ago

ArbitraryExecution

medium

Shadowed variable

Summary

The initialize function takes a named argument, _protocolFee which shadows the protocolFee variable in ProtocolFee.sol

Vulnerability Detail

The TellerV2.sol contract inherits from ProtocolFee.

Impact

None. This is bad coding practice and could lead to errors in the future.

Code Snippet

import "./ProtocolFee.sol";
...
    function initialize(
        uint16 _protocolFee,
...
)

Tool used

Manual Review

Recommendation

Rename _protocolFee in the initialize function.