search

sherlock-audit / 2023-10-real-wagmi-judging

16 stars 14 forks source link

phenom - Governance functions should be controlled by time locks #160

Closed sherlock-admin2 closed 1 year ago

sherlock-admin2 commented 1 year ago

phenom

medium

Governance functions should be controlled by time locks

[M-2] Governance functions should be controlled by time locks

Impact:

Governance functions (such as upgrading contracts, setting critical parameters) should be controlled using time locks to introduce a delay between a proposal and its execution. This gives users time to exit before a potentially dangerous or malicious operation is applied.

Instances (3):

File: LiqBorrowingMan/LiquidityBorrowingManager.sol

184:     function collectProtocol(address recipient, address[] calldata tokens) external onlyOwner {

File: LiqBorrowingMan/Vault.sol

17:     function transferToken(address _token, address _to, uint256 _amount) external onlyOwner {

File: LiqBorrowingMan/abstract/OwnerSettings.sol

65:     function updateSettings(ITEM _item, uint256[] calldata values) external onlyOwner {
sherlock-admin2 commented 1 year ago

1 comment(s) were left on this issue during the judging contest.

tsvetanovv commented:

Information