search

shernshiou / node-uber

Uber API nodejs wrapper
MIT License
188 stars 66 forks source link

Revoke #62

Closed rcurrier666 closed 7 years ago

rcurrier666 commented 7 years ago

Add support for Revoke token function

rcurrier666 commented 7 years ago

Finally had some time to get back to this. Fixed my git branch (still learning git), renamed revoke to revokeToken for clarity, added tests for revokeToken. Uber.js is failing code coverage. Line 183 is mine, the others are not. I have no idea how to test the "happy path" since revokeToken doesn't return anything (revoke is happy if any string is passed in). If someone knows how to test line 183 (return;) let me know and I'll fix the tests. This should be ready for code review and merging now.

agraebe commented 7 years ago

@rcurrier666 thanks for the PR! could you please add tests so that the coverage check doesn't fail anymore?

https://travis-ci.org/shernshiou/node-uber/jobs/255144175#L995

agraebe commented 7 years ago

solved with #64