shgysk8zer0 / awesome-rss

Puts an RSS/Atom subscribe button back in URL bar
https://addons.mozilla.org/en-US/firefox/addon/awesome-rss/
GNU General Public License v3.0
190 stars 22 forks source link

No longer works with tinytinyrss #144

Open TheCoffeMaker opened 3 years ago

TheCoffeMaker commented 3 years ago

Describe the bug TinyTinyRSS API changed and not returns the following error when awesome-rss tries to add a new feed:

 {"error":{"code":"E_UNKNOWN_METHOD","params":[]}}

To Reproduce Steps to reproduce the behavior:

  1. Go to any site with rss feed
  2. Click on the green rss icon
  3. See error

Expected behavior Just expect to get the feed added correctly to tinytinyrss.

Screenshots N/A

Desktop (please complete the following information):

olivierlemoal commented 3 years ago

Same issue here. tt-rss seems to handle plugins a bit differently since last commits, the route for bookmarking changed to public.php?op=bookmarklets--subscribe&feed_url={URL}

Likely introduced by this commit https://git.tt-rss.org/fox/tt-rss/commit/273ada7353b185e20452d54a8206d5e0cef9e573

shgysk8zer0 commented 3 years ago

@TheCoffeMaker Looks like Mozilla will soon be removing page actions from the URL/awesome bar, and that'll be the end of Awesome RSS. First the removed the RSS when the removed RSS from Firefox, now they're removing the "Awesome" part with the removal of page actions.

efermi commented 3 years ago

Looks like Mozilla will soon be removing page actions from the URL/awesome bar

@shgysk8zer0 Sorry for the off-topic question, but any more info on that?

olivierlemoal commented 2 years ago

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/pageAction does not mention any forthcoming deprecation, any news on this ?

LSchuepbach commented 2 years ago

I am also affected. Would it be possible to make this change? I understand Firefox might one day change, but I see this was feared since at least 2018 (see https://github.com/shgysk8zer0/awesome-rss/issues/92).

Letting user set the URL completely with parameters just like https://example.org/homegrownrss.php?foo=bar&url=%s would make sure you don't have to update for every change in nextcloud, tt-rss or every obscure service there is.

hockeymikey commented 1 year ago

Why wasn't this updated sooner? It was literally one word, took me like 5min total. Well it's out for PR now, confirmed working locally for me! This never effected me until recently because I had never updated my TT-RSS instance.

Krysztophe commented 9 months ago

The problem is still there. Such a shame. @hockeymikey says he has a fix, if I understand correctly. Any chance to merge #165 and release ?

hockeymikey commented 9 months ago

Here you go: https://cloud.hockeymikey.com/s/ie76xf3sjx7r6fg

EarMaster commented 6 months ago

Is there a reason why the Pull Request #165 isn't merged?

rubinlinux commented 2 months ago

This is affecting me also.

I took a look at PR #165 and it is very trivial and easy to identify as not malicious (Changing only 'subscribe' to 'bookmarklets--subscribe'). I hope you can find a few minutes to do another release with this merged in. Thanks!

rubinlinux commented 2 months ago

As a work around:

Go into tt-rss preferences, in the 'feeds' tab, under Bookmarklets. Drag the 'Share with Tiny Tiny RSS' button into your toolbar or bookmarks. Then you can just click it to sub to tt-rss on any page without awesome rss extension.

Krysztophe commented 2 months ago

As a work around:

Go into tt-rss preferences, in the 'feeds' tab, under Bookmarklets. Drag the 'Share with Tiny Tiny RSS' button into your toolbar or bookmarks. Then you can just click it to sub to tt-rss on any page without awesome rss extension.

Many thanks for pointing this! :+1:

I had to enable Bookmarklets in the Plugin section (and click on Enable Selected). The "Subscribe in Tiny Tiny RSS " button appears in "Feeds"/"Plugins". It seems to work.