Closed ejfinneran closed 5 months ago
nice catch! it looks like we're running: nginx version: nginx/1.17.8
on production.
( i attached to the running docker nginx container, and used: nginx -v
)
Great! Updated the PR.
rocking, thanks! i'll try pulling it down tomorrow. we generally only merge backend prs when we have meetings ( because merging triggers a deploy, and it's good to have multiple eyes if something unexpected goes sideways ) -- so maybe monday, if folks are able to get together then.
tested locally and ./shift rebuild
pulls down and successfully runs the correct version for me. ( production will already have that version, so ./shift pull
shouldn't wind up doing anything special )
looks good.
Great fix @ejfinneran, thanks!
We use the 'ssl' directive which was marked as deprecated in 1.15 of nginx and removed in 1.25.1 so if you run run
shift up
on a new machine, you'll get a version of nginx that doesn't support our configI took a guess and pinned this at 1.15 but it probably makes more sense to match this to the version running in production. If someone can share that with me, I can update this PR.
See: https://nginx.org/en/docs/http/ngx_http_ssl_module.html#ssl